From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/9] dt-bindings: clock: ipq5332: drop the few nss clocks definition
Date: Wed, 22 Nov 2023 11:12:40 +0100 [thread overview]
Message-ID: <d26eae8d-4968-4ab0-bd9b-696d7b3865ec@linaro.org> (raw)
In-Reply-To: <8bb79735-3b5d-4229-b0f4-bc50d61fdba1@quicinc.com>
On 22/11/2023 11:08, Kathiravan Thirumoorthy wrote:
>
>
> On 11/21/2023 8:36 PM, Krzysztof Kozlowski wrote:
>> On 21/11/2023 15:30, Kathiravan Thirumoorthy wrote:
>>> In commit 0dd3f263c810 ("clk: qcom: ipq5332: enable few nssnoc clocks in
>>
>> Where is this commit coming from?
>>
>>> driver probe"), gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk,
>>> gcc_nssnoc_nsscc_clk are enabled in driver probe to keep it always-on.
>>
>> Implementation can change and for example bring back these clocks. Are
>> you going to change bindings? No, drop the patch.
>>
>> Bindings should be dropped only in a few rare cases like clocks not
>> available for OS or bugs.
>
> Thanks Krzysztof. Will drop this patch in V3.
>
> One more question to understand further. In IPQ SoCs there are bunch of
> coresight / QDSS clocks but coresight framework doesn't handle all
> clocks. Those clocks are enabled in bootloader stage itself. In such
> case, should I drop the clocks from both binding and driver or only from
> driver?
That's not really the reason to drop them at all. Neither from driver,
nor from bindings. You should not rely on bootloader handling your clocks
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-22 10:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 14:30 [PATCH v2 0/9] Add NSS clock controller support for Qualcomm IPQ5332 Kathiravan Thirumoorthy
2023-11-21 14:30 ` [PATCH v2 1/9] clk: qcom: ipq5332: add const qualifier to the clk_init_data structure Kathiravan Thirumoorthy
2023-11-22 16:31 ` Konrad Dybcio
2023-11-21 14:30 ` [PATCH v2 2/9] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Kathiravan Thirumoorthy
2023-11-22 16:32 ` Konrad Dybcio
2023-11-21 14:30 ` [PATCH v2 3/9] dt-bindings: clock: ipq5332: drop the few nss clocks definition Kathiravan Thirumoorthy
2023-11-21 15:06 ` Krzysztof Kozlowski
2023-11-22 10:08 ` Kathiravan Thirumoorthy
2023-11-22 10:12 ` Krzysztof Kozlowski [this message]
2023-11-22 10:18 ` Kathiravan Thirumoorthy
2023-11-22 10:23 ` Dmitry Baryshkov
2023-11-22 10:45 ` Kathiravan Thirumoorthy
2023-11-21 14:30 ` [PATCH v2 4/9] dt-bindings: clock: ipq5332: add definition for GPLL0_OUT_AUX clock Kathiravan Thirumoorthy
2023-11-21 14:30 ` [PATCH v2 5/9] clk: qcom: ipq5332: add gpll0_out_aux clock Kathiravan Thirumoorthy
2023-11-22 20:22 ` Konrad Dybcio
2023-11-21 14:30 ` [PATCH v2 6/9] dt-bindings: clock: add Qualcomm IPQ5332 NSSCC clock and reset definitions Kathiravan Thirumoorthy
2023-11-21 14:30 ` [PATCH v2 7/9] clk: qcom: add NSS clock Controller driver for Qualcomm IPQ5332 Kathiravan Thirumoorthy
2023-11-22 20:20 ` Konrad Dybcio
2023-11-23 7:14 ` Kathiravan Thirumoorthy
2023-11-24 13:19 ` kernel test robot
2023-11-21 14:30 ` [PATCH v2 8/9] arm64: dts: qcom: ipq5332: add support for the NSSCC Kathiravan Thirumoorthy
2023-11-22 20:22 ` Konrad Dybcio
2023-11-23 7:13 ` Kathiravan Thirumoorthy
2023-11-21 14:30 ` [PATCH v2 9/9] arm64: defconfig: build NSS Clock Controller driver for Qualcomm IPQ5332 Kathiravan Thirumoorthy
2023-11-21 15:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26eae8d-4968-4ab0-bd9b-696d7b3865ec@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=quic_kathirav@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).