From: Michal Simek <michal.simek@amd.com>
To: Rob Herring <robh@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH] dt-bindings: soc: Add new board description for Versal NET
Date: Tue, 21 Jan 2025 08:51:36 +0100 [thread overview]
Message-ID: <d28a25ed-f3d7-41dd-b492-618c9c169fed@amd.com> (raw)
In-Reply-To: <20250110160056.GA2939302-robh@kernel.org>
On 1/10/25 17:00, Rob Herring wrote:
> On Wed, Jan 08, 2025 at 05:03:38PM +0530, Shubhrajyoti Datta wrote:
>> The Versal NET (Networked Adaptive Compute Acceleration Platform) from
>> AMD/Xilinx is a next-generation adaptive platform designed for high
>> performance computing, networking, and AI acceleration. It is part of the
>> Versal ACAP (Adaptive Compute Acceleration Platform) family.
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
>> ---
>>
>> Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
>> index 131aba5ed9f4..e0fa36be7e35 100644
>> --- a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
>> +++ b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
>> @@ -10,7 +10,7 @@ maintainers:
>> - Michal Simek <michal.simek@amd.com>
>>
>> description: |
>> - Xilinx boards with Zynq-7000 SOC or Zynq UltraScale+ MPSoC
>> + Xilinx boards with Zynq-7000 SOC or Zynq UltraScale+ MPSoC or Versal Adaptive SoCs
>
> Perhaps make this more general instead of adding to it for each SoC.
>
> Also, the '|' can be dropped while you are here.
It should be likely AMD/Xilinx SOCs
>
>>
>> properties:
>> $nodename:
>> @@ -187,6 +187,10 @@ properties:
>> - const: qemu,mbv
>> - const: amd,mbv
>>
>> + - description: Xilinx Versal NET
>
> Above you say "Versal Adaptive", but not here?
Family is marked as Versal Adaptive SOCs which contains couple of products.
Versal, Versal NET or Versal Gen 2.
Thanks,
Michal
next prev parent reply other threads:[~2025-01-21 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 11:33 [PATCH] dt-bindings: soc: Add new board description for Versal NET Shubhrajyoti Datta
2025-01-08 11:47 ` Krzysztof Kozlowski
2025-01-08 15:27 ` Michal Simek
2025-01-10 16:00 ` Rob Herring
2025-01-21 7:51 ` Michal Simek [this message]
2025-01-22 16:03 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d28a25ed-f3d7-41dd-b492-618c9c169fed@amd.com \
--to=michal.simek@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).