devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wilson Ding <dingwei@marvell.com>, "Rob Herring (Arm)" <robh@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Sanghoon Lee <salee@marvell.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	Geethasowjanya Akula <gakula@marvell.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>
Subject: Re: [EXTERNAL] Re: [PATCH v3 1/3] dt-bindings: reset: Add Armada8K reset controller
Date: Fri, 28 Feb 2025 07:52:31 +0100	[thread overview]
Message-ID: <d2929546-27de-4893-a611-dd4a3bca1a64@kernel.org> (raw)
In-Reply-To: <BY3PR18MB467346EB1FA7CEF0A3300350A7CD2@BY3PR18MB4673.namprd18.prod.outlook.com>

On 27/02/2025 22:58, Wilson Ding wrote:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-
>> ci/linux/Documentation/devicetree/bindings/reset/marvell,armada8k-
>> reset.example.dtb: system-controller@440000: compatible: ['syscon', 'simple-
>> mfd'] is too short
>> 	from schema $id: https://urldefense.proofpoint.com/v2/url?u=http-
>> 3A__devicetree.org_schemas_mfd_syscon-2Dcommon.yaml-
>> 23&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=sXDQZu4GyqNVDlFUXakS
>> GJl0Dh81ZIPlU26YS4KHGIA&m=xw0M--
>> 2th9TCt05M0q_c8C0jvg1t4qbuXx9_d3WgCc0HOBpg5_f5E6TjXP_xdcrU&s=3
>> Gdm4ABV10PnYEpAvJXrV9x-TsfBAHIp5KCn60ohngM&e=
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://urldefense.proofpoint.com/v2/url?u=https-
>> 3A__patchwork.ozlabs.org_project_devicetree-
>> 2Dbindings_patch_20250227192536.2426490-2D2-2Ddingwei-
>> 40marvell.com&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=sXDQZu4GyqN
>> VDlFUXakSGJl0Dh81ZIPlU26YS4KHGIA&m=xw0M--
>> 2th9TCt05M0q_c8C0jvg1t4qbuXx9_d3WgCc0HOBpg5_f5E6TjXP_xdcrU&s=
>> WJznALBWhejS9hq88jCvZqevaNdN_5-meKfowRfl-bA&e=
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your
>> schema.
> 
> I cannot reproduce the above error with the latest 'yamllint' and 'dt-schema'.
> 
> $ pip3 install dtschema --upgrade
> Requirement already satisfied: dtschema in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (2025.2)
> Requirement already satisfied: ruamel.yaml>0.15.69 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (0.18.10)
> Requirement already satisfied: jsonschema<4.18,>=4.1.2 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (4.17.3)
> Requirement already satisfied: rfc3987 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (1.3.8)
> Requirement already satisfied: pylibfdt in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (1.7.2)
> Requirement already satisfied: attrs>=17.4.0 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (25.1.0)
> Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (0.20.0)
> Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from ruamel.yaml>0.15.69->dtschema) (0.2.12)
> $ pip3 install yamllint
> Requirement already satisfied: yamllint in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (1.35.1)
> Requirement already satisfied: pathspec>=0.5.3 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from yamllint) (0.12.1)
> Requirement already satisfied: pyyaml in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from yamllint) (6.0.2)
> $ make dt_binding_check
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   CHKDT   ./Documentation/devicetree/bindings
>   LINT    ./Documentation/devicetree/bindings
>   DTEX    Documentation/devicetree/bindings/reset/marvell,armada8k-reset.example.dts
>   DTC [C] Documentation/devicetree/bindings/reset/marvell,armada8k-reset.example.dtb
> 

That's a bit odd but anyway warning is correct: you cannot have such
compatibles alone.

Best regards,
Krzysztof

  reply	other threads:[~2025-02-28  6:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 19:25 [PATCH v3 0/3] Add Armada8K reset controller support Wilson Ding
2025-02-27 19:25 ` [PATCH v3 1/3] dt-bindings: reset: Add Armada8K reset controller Wilson Ding
2025-02-27 20:24   ` Rob Herring (Arm)
2025-02-27 21:58     ` [EXTERNAL] " Wilson Ding
2025-02-28  6:52       ` Krzysztof Kozlowski [this message]
2025-03-07  0:03         ` Wilson Ding
2025-03-07  8:56           ` Krzysztof Kozlowski
2025-03-07 23:15             ` Wilson Ding
2025-02-28  6:55   ` Krzysztof Kozlowski
2025-02-27 19:25 ` [PATCH v3 2/3] reset: Add support for " Wilson Ding
2025-02-27 19:25 ` [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node Wilson Ding
2025-02-28  6:56   ` Krzysztof Kozlowski
2025-02-28 20:18     ` [EXTERNAL] " Wilson Ding
2025-03-01 13:46       ` Krzysztof Kozlowski
2025-03-01 13:49         ` Krzysztof Kozlowski
2025-03-04  2:17         ` Wilson Ding
2025-03-04  7:13           ` Krzysztof Kozlowski
2025-03-04 19:08             ` Wilson Ding
2025-03-06  7:29               ` Krzysztof Kozlowski
2025-03-06 17:42                 ` [EXTERNAL] " Wilson Ding
2025-03-07  8:59                   ` Krzysztof Kozlowski
2025-03-07 21:52                     ` Wilson Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2929546-27de-4893-a611-dd4a3bca1a64@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dingwei@marvell.com \
    --cc=gakula@marvell.com \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=salee@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).