From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193242D5418 for ; Thu, 24 Jul 2025 13:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753365535; cv=none; b=fPifFETUhmNBVFBJffW2iKa8y0RAZlp15xwksK1Fo4lP1q52tVYQNO37PcmiLtRTythpvpO6hSMTAVeXmaWmYVDCF/iRTpMk5k2kDVL2NBy7DoABrK9O3xsI0ec06ZKQ/hCZgMmX+k1UzdMhnNsb2H+NnHM5MjCw2e/jusTVnRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753365535; c=relaxed/simple; bh=r8m0H60OOKOoeR/NbCqxjR9n2Mi89/uUoIKCUGbAQns=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aABts9Js0Pu/EPlrr7hdbNeHtm74GR9BSY+vTh7+L9hW8BJCumqqdz1fWumyrpQ/0nmcolq/GlzTX2/9mi8M1X/goDzaTfNIwG02qAqXlCMAdmZOWWoshhoP6NQziHlO3Qj9ZgnfX+hNqNowK59Tfr8WfG6TlAk87NnTJUpRAvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PbQfqYEe; arc=none smtp.client-ip=209.85.161.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PbQfqYEe" Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-6159fb8b2aaso502561eaf.0 for ; Thu, 24 Jul 2025 06:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1753365532; x=1753970332; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n8lhkGM6eZ06qMIeQSqBFlLSi5hic1SbTRnA9SoJkZU=; b=PbQfqYEe2Za1lQGP9TtLH+GROHBbNby4i5mr2IxOceP2kFqxinT9JZFFfEYiBcQjLb xUQF1aafLpIfMI2zOX3dZ4cChUTmDRt6ZTNFBsdMpfXXja3bRo5TENQAywKb9LBo6UAk DC6oxb4f7BAcusD2lnC7CftQeP7rqx/a+gXAXZyVUP0M0K6tPu/YKD1FSvBt75iSVolp vrkgKP7IReNhzxygWuxZezFdQNIGrAHp+tXBWKsp7eOMZNkf1nFCICx11pIlqk6LHQ7b ev1cI7MdOKr8mTz1UL6sStD01h8yGDABvaVeqeo8RV9KLe0GW63OkjclFG66N2O135Ut WFAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753365532; x=1753970332; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n8lhkGM6eZ06qMIeQSqBFlLSi5hic1SbTRnA9SoJkZU=; b=YfmSJMxq9lWHV4qdZoAqkZw10hZbTeBfNwyWY+C3Xp//1c4k2zTOSqrZdPdW34i6Us f0Jf1UEISpL16QI4EEQERkqG39krp7grOQUFy4VvbP8XqCc+gPLV3FCI9C9TVcIFGvTd ydM0R30mclu4NAaopjMHBbCLgwWWgubAaLcD31Ib/AqFU5f45yXNvG49NiJUmGkCqyOt lHhppwIyxWkpwdgjGlIPJ8GL6zUnjGxTrIZF2MoG8fcnX5eePlleGUUB0ezG2NV/b/nW c+UOzYUHXEz4v1O+71JR8Ph9F2MxiUSo0ewLt736F+4f0zZUgTkLfsHQU4RDuAp6k1dE T+cA== X-Forwarded-Encrypted: i=1; AJvYcCXtADyUC8mRseK0l0uxSBOAY6mj+fmZ2iWsiHMhj98269LclmMP8olf8Wgkb04GCSErXr0qPd+FrzI9@vger.kernel.org X-Gm-Message-State: AOJu0YxjnhxupXtelnHbKJqDXUQ38afIwwatbOF24rtk7LeTTC7HpyX2 yeTjrJU80mOrQ1h/t46qwYA357yi+2ulI9AmvraCnSStvRs22ozAIimnzpJ7+WR4kLKXygrxTVV lGRLv X-Gm-Gg: ASbGncsyhpWFrrbuzc2mlTyJUzdEquaheIwbUUTzqqUSoXYGkyEHY1FTe/1JJNtSB6J XcwzbMP7Qr/HeF6UtmmJvSdG315M3Btv+CI4uTj/eIjbn87KUn0ANU016xpDGBhA++gIlj918zf AMSxImP0d08xGmrmg+dLqeomnK+q3chCA+aCy/RLOxMfijzdte6NLb38DZ2rZoyB2NBHQMuDjZ+ /21g4yqVemnnFTXCJ73lCD8KHSy+ozQf+xxsfO0rVtMl5jKitkbJTDfKv5lj+SqkgVQ8V4WcnKO 8aqZ5BrbIkguurSjrh0zeRbocmCQFOsroCjyh2siWxyaZNJ1x6+pyTWO1UCs4/t52VaRpEsqCbr 3Y35ra0LO9DdHm6LmpfV81I5xc07apkyOO7hV2AvQXdoFbj97C8LwOF6/MU/iFsZcLlR5aaaIj5 c= X-Google-Smtp-Source: AGHT+IHZQzg7kaDuAlFKlh3XPZNFCAFVXmInWE92TfWbiWLHeoiep/6LdiR6Fg9xqiYfhuX5RRglmQ== X-Received: by 2002:a05:6820:6ac1:b0:615:c215:6134 with SMTP id 006d021491bc7-61873284b83mr5671009eaf.4.1753365532107; Thu, 24 Jul 2025 06:58:52 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:9829:e9f9:e475:a206? ([2600:8803:e7e4:1d00:9829:e9f9:e475:a206]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-618fb44265asm223960eaf.11.2025.07.24.06.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 06:58:50 -0700 (PDT) Message-ID: Date: Thu, 24 Jul 2025 08:58:48 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] iio: add power and energy measurement modifiers To: Jonathan Cameron Cc: Antoniu Miclaus , robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250711130241.159143-1-antoniu.miclaus@analog.com> <20250711130241.159143-2-antoniu.miclaus@analog.com> <1ead013c-56ef-4f11-afb9-2b11e0de7eb2@baylibre.com> <20250724140940.2d9b4a1f@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20250724140940.2d9b4a1f@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/24/25 8:09 AM, Jonathan Cameron wrote: > On Fri, 11 Jul 2025 14:23:14 -0500 > David Lechner wrote: > >> On 7/11/25 8:02 AM, Antoniu Miclaus wrote: >>> Add new IIO modifiers to support power and energy measurement devices: >>> ... > >> >>> >>> Signal quality modifiers: >>> - IIO_MOD_RMS: Root Mean Square value >> >> Suprised we don't have something like this already. altvoltageY isn't >> clear about if the value is peak-to-peak or RMS. > > Hohum.. My vague recollection is peak to peak, but oops we should > have documented that better. Someone want to audit existing drivers? > >> I did audit them (which is what lead to the Q/I modifier cleanup in the ABI docs). Most drivers are just using the frequency and/or phase components. The ads1210 uses peak-to-peak (I should know, I wrote the driver :-p). The envelope-detector driver mentions high and low when making an altvoltage_raw measurement so that sounds like peak-to-peak as well. There are a couple of frequency drivers that also have altvoltage_raw, but I didn't look as closely at them.