* [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible
@ 2022-10-19 17:10 Vincent Knecht
2022-10-19 17:10 ` [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data Vincent Knecht
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vincent Knecht @ 2022-10-19 17:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Vincent Knecht
Document the "qcom,msm8939-saw2-v3.0-cpu" compatible for the CPU
Subsystem Power Manager (SPM) on the MSM8939 SoC.
Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
---
Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
index f433e6e0a19f..8791f8ad2c84 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
@@ -24,6 +24,7 @@ properties:
- qcom,msm8998-silver-saw2-v4.1-l2
- qcom,msm8909-saw2-v3.0-cpu
- qcom,msm8916-saw2-v3.0-cpu
+ - qcom,msm8939-saw2-v3.0-cpu
- qcom,msm8226-saw2-v2.1-cpu
- qcom,msm8974-saw2-v2.1-cpu
- qcom,apq8084-saw2-v2.1-cpu
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data 2022-10-19 17:10 [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Vincent Knecht @ 2022-10-19 17:10 ` Vincent Knecht 2022-10-19 19:55 ` Stephan Gerhold 2022-10-20 10:01 ` Bryan O'Donoghue 2022-10-20 13:50 ` [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Krzysztof Kozlowski 2022-11-07 3:12 ` (subset) " Bjorn Andersson 2 siblings, 2 replies; 6+ messages in thread From: Vincent Knecht @ 2022-10-19 17:10 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel Cc: Vincent Knecht Add SPM register information and initialization values for QCOM MSM8939 SoC. Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> --- drivers/soc/qcom/spm.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c index 484b42b7454e..670775e43f07 100644 --- a/drivers/soc/qcom/spm.c +++ b/drivers/soc/qcom/spm.c @@ -98,6 +98,17 @@ static const struct spm_reg_data spm_reg_8916_cpu = { .start_index[PM_SLEEP_MODE_SPC] = 5, }; +static const struct spm_reg_data spm_reg_8939_cpu = { + .reg_offset = spm_reg_offset_v3_0, + .spm_cfg = 0x1, + .spm_dly = 0x3C102800, + .seq = { 0x60, 0x03, 0x60, 0x0B, 0x0F, 0x20, 0x50, 0x1B, 0x10, 0x80, + 0x30, 0x90, 0x5B, 0x60, 0x50, 0x03, 0x60, 0x76, 0x76, 0x0B, + 0x50, 0x1B, 0x94, 0x5B, 0x80, 0x10, 0x26, 0x30, 0x50, 0x0F }, + .start_index[PM_SLEEP_MODE_STBY] = 0, + .start_index[PM_SLEEP_MODE_SPC] = 5, +}; + static const u16 spm_reg_offset_v2_1[SPM_REG_NR] = { [SPM_REG_CFG] = 0x08, [SPM_REG_SPM_CTL] = 0x30, @@ -211,6 +222,8 @@ static const struct of_device_id spm_match_table[] = { .data = &spm_reg_8909_cpu }, { .compatible = "qcom,msm8916-saw2-v3.0-cpu", .data = &spm_reg_8916_cpu }, + { .compatible = "qcom,msm8939-saw2-v3.0-cpu", + .data = &spm_reg_8939_cpu }, { .compatible = "qcom,msm8974-saw2-v2.1-cpu", .data = &spm_reg_8974_8084_cpu }, { .compatible = "qcom,msm8998-gold-saw2-v4.1-l2", -- 2.37.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data 2022-10-19 17:10 ` [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data Vincent Knecht @ 2022-10-19 19:55 ` Stephan Gerhold 2022-10-20 10:01 ` Bryan O'Donoghue 1 sibling, 0 replies; 6+ messages in thread From: Stephan Gerhold @ 2022-10-19 19:55 UTC (permalink / raw) To: Vincent Knecht Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel, Bryan O'Donoghue + Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org> On Wed, Oct 19, 2022 at 07:10:03PM +0200, Vincent Knecht wrote: > Add SPM register information and initialization values for > QCOM MSM8939 SoC. > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> Thanks! Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > --- > drivers/soc/qcom/spm.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c > index 484b42b7454e..670775e43f07 100644 > --- a/drivers/soc/qcom/spm.c > +++ b/drivers/soc/qcom/spm.c > @@ -98,6 +98,17 @@ static const struct spm_reg_data spm_reg_8916_cpu = { > .start_index[PM_SLEEP_MODE_SPC] = 5, > }; > > +static const struct spm_reg_data spm_reg_8939_cpu = { > + .reg_offset = spm_reg_offset_v3_0, > + .spm_cfg = 0x1, > + .spm_dly = 0x3C102800, > + .seq = { 0x60, 0x03, 0x60, 0x0B, 0x0F, 0x20, 0x50, 0x1B, 0x10, 0x80, > + 0x30, 0x90, 0x5B, 0x60, 0x50, 0x03, 0x60, 0x76, 0x76, 0x0B, > + 0x50, 0x1B, 0x94, 0x5B, 0x80, 0x10, 0x26, 0x30, 0x50, 0x0F }, > + .start_index[PM_SLEEP_MODE_STBY] = 0, > + .start_index[PM_SLEEP_MODE_SPC] = 5, > +}; > + > static const u16 spm_reg_offset_v2_1[SPM_REG_NR] = { > [SPM_REG_CFG] = 0x08, > [SPM_REG_SPM_CTL] = 0x30, > @@ -211,6 +222,8 @@ static const struct of_device_id spm_match_table[] = { > .data = &spm_reg_8909_cpu }, > { .compatible = "qcom,msm8916-saw2-v3.0-cpu", > .data = &spm_reg_8916_cpu }, > + { .compatible = "qcom,msm8939-saw2-v3.0-cpu", > + .data = &spm_reg_8939_cpu }, > { .compatible = "qcom,msm8974-saw2-v2.1-cpu", > .data = &spm_reg_8974_8084_cpu }, > { .compatible = "qcom,msm8998-gold-saw2-v4.1-l2", > -- > 2.37.3 > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data 2022-10-19 17:10 ` [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data Vincent Knecht 2022-10-19 19:55 ` Stephan Gerhold @ 2022-10-20 10:01 ` Bryan O'Donoghue 1 sibling, 0 replies; 6+ messages in thread From: Bryan O'Donoghue @ 2022-10-20 10:01 UTC (permalink / raw) To: Vincent Knecht, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel On 19/10/2022 18:10, Vincent Knecht wrote: > Add SPM register information and initialization values for > QCOM MSM8939 SoC. > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> > --- > drivers/soc/qcom/spm.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c > index 484b42b7454e..670775e43f07 100644 > --- a/drivers/soc/qcom/spm.c > +++ b/drivers/soc/qcom/spm.c > @@ -98,6 +98,17 @@ static const struct spm_reg_data spm_reg_8916_cpu = { > .start_index[PM_SLEEP_MODE_SPC] = 5, > }; > > +static const struct spm_reg_data spm_reg_8939_cpu = { > + .reg_offset = spm_reg_offset_v3_0, > + .spm_cfg = 0x1, > + .spm_dly = 0x3C102800, > + .seq = { 0x60, 0x03, 0x60, 0x0B, 0x0F, 0x20, 0x50, 0x1B, 0x10, 0x80, > + 0x30, 0x90, 0x5B, 0x60, 0x50, 0x03, 0x60, 0x76, 0x76, 0x0B, > + 0x50, 0x1B, 0x94, 0x5B, 0x80, 0x10, 0x26, 0x30, 0x50, 0x0F }, > + .start_index[PM_SLEEP_MODE_STBY] = 0, > + .start_index[PM_SLEEP_MODE_SPC] = 5, > +}; > + > static const u16 spm_reg_offset_v2_1[SPM_REG_NR] = { > [SPM_REG_CFG] = 0x08, > [SPM_REG_SPM_CTL] = 0x30, > @@ -211,6 +222,8 @@ static const struct of_device_id spm_match_table[] = { > .data = &spm_reg_8909_cpu }, > { .compatible = "qcom,msm8916-saw2-v3.0-cpu", > .data = &spm_reg_8916_cpu }, > + { .compatible = "qcom,msm8939-saw2-v3.0-cpu", > + .data = &spm_reg_8939_cpu }, > { .compatible = "qcom,msm8974-saw2-v2.1-cpu", > .data = &spm_reg_8974_8084_cpu }, > { .compatible = "qcom,msm8998-gold-saw2-v4.1-l2", Compared to downstream, init sequence looks the same. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible 2022-10-19 17:10 [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Vincent Knecht 2022-10-19 17:10 ` [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data Vincent Knecht @ 2022-10-20 13:50 ` Krzysztof Kozlowski 2022-11-07 3:12 ` (subset) " Bjorn Andersson 2 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-10-20 13:50 UTC (permalink / raw) To: Vincent Knecht, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel On 19/10/2022 13:10, Vincent Knecht wrote: > Document the "qcom,msm8939-saw2-v3.0-cpu" compatible for the CPU > Subsystem Power Manager (SPM) on the MSM8939 SoC. > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> > --- > Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible 2022-10-19 17:10 [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Vincent Knecht 2022-10-19 17:10 ` [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data Vincent Knecht 2022-10-20 13:50 ` [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Krzysztof Kozlowski @ 2022-11-07 3:12 ` Bjorn Andersson 2 siblings, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2022-11-07 3:12 UTC (permalink / raw) To: krzysztof.kozlowski+dt, devicetree, vincent.knecht, Rob Herring, linux-arm-msm, konrad.dybcio, linux-kernel, Andy Gross On Wed, 19 Oct 2022 19:10:02 +0200, Vincent Knecht wrote: > Document the "qcom,msm8939-saw2-v3.0-cpu" compatible for the CPU > Subsystem Power Manager (SPM) on the MSM8939 SoC. > > Applied, thanks! [1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible commit: 7334ac8b7a332c0f85545ac50e1822cd76029c96 [2/2] soc: qcom: spm: Add MSM8939 SPM register data commit: f98e12a7e0dab30b48a75554510634c06eecd3e5 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-07 3:15 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-19 17:10 [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Vincent Knecht 2022-10-19 17:10 ` [PATCH 2/2] soc: qcom: spm: Add MSM8939 SPM register data Vincent Knecht 2022-10-19 19:55 ` Stephan Gerhold 2022-10-20 10:01 ` Bryan O'Donoghue 2022-10-20 13:50 ` [PATCH 1/2] dt-bindings: soc: qcom: spm: Add MSM8939 CPU compatible Krzysztof Kozlowski 2022-11-07 3:12 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).