Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

Maxime Ripard
2019-04-17T08:06:14Z

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote:
> From: John Crispin <john@phrozen.org>
>
> Many embedded devices have information such as MAC addresses stored
> inside MTD devices. This patch allows us to add a property inside a node
> describing a network interface. The new property points at a MTD
> partition with an offset where the MAC address can be found.
>
> This patch has originated in OpenWrt some time ago, so in order to
> consider usefulness of this patch, here are some real-world numbers
> which hopefully speak for themselves:
>
> * mtd-mac-address used 497 times in 357 device tree files
> * mtd-mac-address-increment used 74 times in 58 device tree files
> * mtd-mac-address-increment-byte used 1 time in 1 device tree file
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> [cleanup of the patch for upstream submission]
> Signed-off-by: Petr Štetiar <ynezz@true.cz>

NVMEM is supported by of_net already and there's an MTD-to-nvmem
bridge already, so it doesn't look really necessary to create
additional properties that cover the same use case.

(or at least, you should explain why nvmem doesn't work there)

Maxime