From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69BC8C77B73 for ; Tue, 30 May 2023 13:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232623AbjE3NUz (ORCPT ); Tue, 30 May 2023 09:20:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232478AbjE3NUx (ORCPT ); Tue, 30 May 2023 09:20:53 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A58E6D9 for ; Tue, 30 May 2023 06:20:51 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5147f4bbfdaso5718739a12.0 for ; Tue, 30 May 2023 06:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685452850; x=1688044850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ea2LdewWSYBlTGL1pC0uVnJLZZioO8cfJgJDEPtNoG8=; b=qvydoxNAZHcUiT+Wxla0aaBfxHooTFXK0IF/Trw7A2o/U95eS5pNGk7nya8DU3YaHN VqSVNL8jYNpuvaMHVgCheZfgdBYEivZuPcOXK2wo0noNfFepqoA8vw/wYg/dXBRkXiK5 jbgKSMCokog2ZTK6X5VD4tK1bCoKDOk/JemiAimkGQ92Rqh711M8pa9yyEVMT0g034dW iK2w9byBhHkDClsxWReyXeebR0jD2fus3SA/TKkJMPYK5qKVTLxO0H8330wH2m5nL3Ac hsN891MLZjnN9/8xa7GMqvdRtdKOcxFyZCz0pEfO8uMWCW4QU2SbvHV5gDvhphB3dzBB SU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685452850; x=1688044850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ea2LdewWSYBlTGL1pC0uVnJLZZioO8cfJgJDEPtNoG8=; b=AE9DA5yRBe6pteqvtcbTYqYr6gLGuNu1nsT7GSpUZVXlIQNvBipuxglvC63eYIGmX/ tsr6QZoE0SvxE9OnrVM3J30GzWe58uCo4IgMQHVIN98ayBoGz3ihgewcn2X9sgjtugGd XWwrPZcHKxCcAt9cTRUh8dve0UE/aC3Fh9qCsVYSHDjJmsCpBHRwNFPclpH4EUxJptl/ savCWjq5oAgrTV6mAnmYyens7IypU0992TraQmYLAvmNdR+SV5vvirdcIw3YW9VBhwbg T9tN9wGqQv3ZYEMTqj8Kcj7ADA0YRwk9lxxczEfC/ShIBUwgmtB+9LABv7Kps0vUkSfe dZyA== X-Gm-Message-State: AC+VfDywEf5BJdZpiVpg9492P449AhFxNtCA9MrW+PjeckicY+nA1jvM A6jjDsRaANoFxSfmf1AdV/Iw5g== X-Google-Smtp-Source: ACHHUZ5Ec8mS0WQOTPmfsRcm8kG86wAB7r6cdlwRv8fyLj+55BTyGZ0d5j3fIeUVp34EMJ4rhBObtg== X-Received: by 2002:aa7:ce0c:0:b0:514:9422:37db with SMTP id d12-20020aa7ce0c000000b00514942237dbmr1488683edv.39.1685452850273; Tue, 30 May 2023 06:20:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id i12-20020aa7dd0c000000b005149c3fa632sm2798999edv.13.2023.05.30.06.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 06:20:49 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 15:20:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 5/5] ARM: Add Samsung Galaxy Express support Content-Language: en-US To: Rudraksha Gupta , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: david@ixit.cz, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230524230459.120681-1-guptarud@gmail.com> <20230524230459.120681-5-guptarud@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230524230459.120681-5-guptarud@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/05/2023 01:04, Rudraksha Gupta wrote: > This adds a very basic device tree file for the Samsung Galaxy Express > SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and > USB. > > Signed-off-by: Rudraksha Gupta > --- > + > +&usb_hs1_phy { > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l4>; > +}; > + > +&usb1 { > + status = "okay"; > + dr_mode = "otg"; > +}; > + except what was said - drop stray blank line. Best regards, Krzysztof