Re: [PATCH v2 1/3] dt/bindings: da8xx-usb: Add binding for the CPPI 4.1 DMA controller

[Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]

On 01/17/2017 05:20 PM, Alexandre Bailon wrote:

> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller.

    "CPPI 4.1 DMA" again.

>
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  .../devicetree/bindings/usb/da8xx-usb.txt          | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> index ccb844a..aed3169 100644
> --- a/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -18,10 +18,26 @@ Required properties:
>
>   - phy-names: Should be "usb-phy"
>
> + - dmas: specifies the dma channels
> +
> + - dma-names: specifies the names of the channels. Use "rxN" for receive
> +   and "txN" for transmit endpoints. N specifies the endpoint number.
> +
>  Optional properties:
>  ~~~~~~~~~~~~~~~~~~~~
>   - vbus-supply: Phandle to a regulator providing the USB bus power.
>
> +DMA
> +~~~
> +- compatible: ti,da8xx-cppi41
> +- reg: offset and length of the following register spaces: CPPI DMA Controller,
> +  CPPI DMA Scheduler, Queue Manager
> +- reg-names: "controller", "scheduler", "queuemgr"
> +- #dma-cells: should be set to 2. The first number represents the
> +  channel number (0 … 3 for endpoints 1 … 4).
> +  The second number is 0 for RX and 1 for TX transfers.
> +- #dma-channels: should be set to 4 representing the 4 endpoints.

    Shouldn't the # of channels be a part of the glue data?

[...]
> @@ -39,5 +58,28 @@ Example:
>  		phys = <&usb_phy 0>;
>  		phy-names = "usb-phy";
>
> +		dmas = <&cppi41dma 0 0 &cppi41dma 1 0
> +			&cppi41dma 2 0 &cppi41dma 3 0
> +			&cppi41dma 0 1 &cppi41dma 1 1
> +			&cppi41dma 2 1 &cppi41dma 3 1>;
> +		dma-names =
> +			"rx1", "rx2", "rx3", "rx4",
> +			"tx1", "tx2", "tx3", "tx4";
> +
>  		status = "okay";
> +
> +		cppi41dma: dma-controller@201000 {
> +			compatible = "ti,da8xx-cppi41";
> +			reg =  <0x201000 0x1000
> +				0x202000 0x1000
> +				0x204000 0x4000>;
> +			reg-names = "controller", "scheduler", "queuemgr";
> +			interrupts = <58>;
> +			interrupt-names = "glue";
> +			#dma-cells = <2>;
> +			#dma-channels = <4>;
> +			#dma-requests = <256>;

    Not seeing this prop documented...

> +			status = "okay";

    Can be omitted.

> +		};
> +
>  	};
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html