devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hansverk@cisco.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Tim Harvey <tharvey@gateworks.com>
Cc: linux-media <linux-media@vger.kernel.org>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Mauro Carvalho Chehab <mchehab@s-opensource.com>
Subject: Re: [PATCH v8 0/7] TDA1997x HDMI video reciver
Date: Thu, 8 Feb 2018 16:29:32 +0100	[thread overview]
Message-ID: <d2d376ef-c74e-3df0-01b3-3ab606664dba@cisco.com> (raw)
In-Reply-To: <1518102837.4359.6.camel@pengutronix.de>

On 02/08/18 16:13, Philipp Zabel wrote:
> On Thu, 2018-02-08 at 13:01 +0100, Hans Verkuil wrote:
>>> These are likely to be filled correctly already. I've just added a commit
>>> to v4l2-compliance to make it easier to see what function is used:
>>>
>>> 	v4l2-compliance -m0 -v
>>
>> Actually, can you run this using the latest v4l-utils version for the imx
>> and post the output?
> 
> I have tried with v4l-utils-1.14.0-111-g542af94c on a platform with a
> Toshiba TC358743 connected via MIPI CSI-2. Apart from a crash [1], I get
> a few:
> - missing G_INPUT on the capture devices - is that really a bug?

Depends who you ask :-)  It's an open issue, we had a patch for this that
was never picked up. Hopefully this will resurrect that patch.

> - cap->timeperframe.numerator == 0 || cap->timeperframe.denominator == 0,
>   where there is nothing connected that could provide timing information
> - missing enum_mbus_code
> - check_0(reserved) errors on subdev ioctls

Should be fixed by https://patchwork.linuxtv.org/patch/46955/ and
https://patchwork.linuxtv.org/patch/46950/

> - node->enum_frame_interval_pad != (int)pad
> - subscribe event failures
> - g_ext_ctrls does not support count == 0 (which no subdev implements)

Was this patch applied? https://patchwork.linuxtv.org/patch/46958/
That will probably fix this fail.

> 
> [1] https://patchwork.linuxtv.org/patch/46979/
> 
> The CSIs are currently marked as pixel formatters instead of IF bridges,
>   
> the vdics are marked as pixel formatters instead of deinterlacers, and
> the ic_prp is marked as scaler instead of video splitter. The other
> entity functions are initialized correctly.

Thanks for testing this!

	Hans

> Total: 1307, Succeeded: 1089, Failed: 218, Warnings: 4

Total: 1307

Cool!

	Hans

      reply	other threads:[~2018-02-08 15:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 20:27 [PATCH v8 0/7] TDA1997x HDMI video reciver Tim Harvey
     [not found] ` <1517948874-21681-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2018-02-06 20:27   ` [PATCH v8 1/7] v4l2-dv-timings: add v4l2_hdmi_colorimetry() Tim Harvey
2018-02-07  1:22     ` Randy Dunlap
2018-02-06 20:27   ` [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver Tim Harvey
     [not found]     ` <1517948874-21681-6-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2018-02-06 20:38       ` Hans Verkuil
2018-02-06 21:03         ` Tim Harvey
2018-02-06 21:09           ` Hans Verkuil
2018-02-06 20:27 ` [PATCH v8 2/7] media: v4l-ioctl: fix pad for VIDIOC_DV_TIMIGNS_CAP Tim Harvey
2018-02-06 20:27 ` [PATCH v8 3/7] MAINTAINERS: add entry for NXP TDA1997x driver Tim Harvey
2018-02-06 20:27 ` [PATCH v8 4/7] media: dt-bindings: Add bindings for TDA1997X Tim Harvey
2018-02-06 20:27 ` [PATCH v8 6/7] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx Tim Harvey
2018-02-06 20:27 ` [PATCH v8 7/7] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x Tim Harvey
2018-02-06 21:21 ` [PATCH v8 0/7] TDA1997x HDMI video reciver Hans Verkuil
     [not found]   ` <c7771c44-a9ff-0207-38f6-28bcc06ccdee-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2018-02-06 23:29     ` Tim Harvey
2018-02-07  8:22       ` Hans Verkuil
2018-02-07  9:09         ` Hans Verkuil
2018-02-07 22:05           ` Tim Harvey
2018-02-07 22:19             ` Hans Verkuil
2018-02-08 10:46               ` Philipp Zabel
2018-02-08 11:56                 ` Hans Verkuil
2018-02-08 12:01                   ` Hans Verkuil
2018-02-08 15:13                     ` Philipp Zabel
2018-02-08 15:29                       ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2d376ef-c74e-3df0-01b3-3ab606664dba@cisco.com \
    --to=hansverk@cisco.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@s-opensource.com \
    --cc=p.zabel@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=slongerbeam@gmail.com \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).