devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yu-Chun Lin [林祐君]" <eleanor.lin@realtek.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
	"afaerber@suse.de" <afaerber@suse.de>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>,
	"James Tai [戴志峰]" <james.tai@realtek.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-realtek-soc@lists.infradead.org"
	<linux-realtek-soc@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"CY_Huang[黃鉦晏]" <cy.huang@realtek.com>,
	"Stanley Chang[昌育德]" <stanley_chang@realtek.com>
Subject: RE: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller
Date: Wed, 19 Nov 2025 06:46:23 +0000	[thread overview]
Message-ID: <d2dbb700ce684ee4a4c4ca120ac5e4e4@realtek.com> (raw)
In-Reply-To: <38d7aacd-1c05-4040-8575-bdec0587e08f@kernel.org>

> On 17/11/2025 13:41, Yu-Chun Lin [林祐君] wrote:
> >>>
> >>
> >> None of them. You need SoC specific compatibles which can be used as
> >> fallbacks for SoC specific compatibles. There is plenty of examples
> >> for this already, but anyway this does not solve the problem that you
> >> still did not properly describe the hardware but instead use your
> >> downstream as arguments.
> >>
> >> This will get you nowhere.
> >
> > To implement this fallback structure, my understanding is that the
> > SoC-level DTSI should override the node and prepend its SoC-specific
> > Compatible, while the common DTSI only provides the family-level
> > compatible.
> >
> > /* common DTSI */
> > misc: syscon@... {
> >     compatible = "realtek,kent-misc", "syscon", "simple-mfd";
> 
> No. You changed nothing. How does this differ from options I disagreed with?
> 
> Anyway, there is no such SoC as "kent" and I was clear - you need SoC
> compatibles.
> 
> Define what is your SoC first.
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Thank you for your response.

The original intention was to add a basic Kent device tree, but since the
'misc' node is currently empty. I will remove both this device node and
its corresponding YAML binding in v3.

After further consideration within our team, we have decided to add
power-domain and reboot-mode functionalities to the 'misc' node in the
future. And we will adhere to the SoC-specific compatible string binding
pattern, following this structure:

/* schema binding */
compatible:
  items:
    - enum:
        - realtek,rtd1501-misc
        - realtek,rtd1861-misc
        - realtek,rtd1920-misc
    - const: syscon
    - const: simple-mfd

/* SoC-specific Device Tree Source (e.g. rtd1920s.dtsi) */

&rbus {
  misc: syscon@7000 {
    compatible = "realtek,rtd1920-misc", "syscon", "simple-mfd";
    reg = <0x7000 0x1000>;
    ranges = <0x0 0x7000 0x1000>;
    #address-cells = <1>;
    #size-cells = <1>;
  };
};

Best regards,
Yu-Chun

  reply	other threads:[~2025-11-19  6:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 12:30 [PATCH v2 0/3] arm64: dts: Add support for Kent SoC family Yu-Chun Lin
2025-11-13 12:30 ` [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin
2025-11-13 19:28   ` Conor Dooley
2025-11-17 10:55     ` Yu-Chun Lin
2025-11-17 14:36       ` Conor Dooley
2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin
2025-11-13 19:31   ` Conor Dooley
2025-11-13 19:36   ` Krzysztof Kozlowski
2025-11-17 11:03   ` Yu-Chun Lin [林祐君]
2025-11-17 11:10     ` Krzysztof Kozlowski
2025-11-17 12:41       ` Yu-Chun Lin [林祐君]
2025-11-17 13:31         ` Krzysztof Kozlowski
2025-11-19  6:46           ` Yu-Chun Lin [林祐君] [this message]
2025-11-13 12:30 ` [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin
2025-11-13 19:39   ` Krzysztof Kozlowski
2025-11-13 19:50   ` Krzysztof Kozlowski
2025-11-17 12:43     ` Yu-Chun Lin [林祐君]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2dbb700ce684ee4a4c4ca120ac5e4e4@realtek.com \
    --to=eleanor.lin@realtek.com \
    --cc=afaerber@suse.de \
    --cc=conor+dt@kernel.org \
    --cc=cy.huang@realtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=james.tai@realtek.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stanley_chang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).