From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>, x86@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: of: Kill unused early_init_dt_scan_chosen_arch()
Date: Sun, 24 Oct 2021 23:26:58 -0500 [thread overview]
Message-ID: <d3013783-b5b6-6a60-17c1-4bd65004dd5e@gmail.com> (raw)
In-Reply-To: <20211022164642.2815706-1-robh@kernel.org>
On 10/22/21 11:46 AM, Rob Herring wrote:
> There are no callers for early_init_dt_scan_chosen_arch(), so remove it.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/x86/kernel/devicetree.c | 5 -----
> include/linux/of_fdt.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 3aa1e99df2a9..5cd51f25f446 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -31,11 +31,6 @@ char __initdata cmd_line[COMMAND_LINE_SIZE];
>
> int __initdata of_ioapic;
>
> -void __init early_init_dt_scan_chosen_arch(unsigned long node)
> -{
> - BUG();
> -}
> -
> void __init early_init_dt_add_memory_arch(u64 base, u64 size)
> {
> BUG();
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index cf6a65b94d40..cf48983d3c86 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -65,7 +65,6 @@ extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
> extern int early_init_dt_scan_chosen_stdout(void);
> extern void early_init_fdt_scan_reserved_mem(void);
> extern void early_init_fdt_reserve_self(void);
> -extern void __init early_init_dt_scan_chosen_arch(unsigned long node);
> extern void early_init_dt_add_memory_arch(u64 base, u64 size);
> extern u64 dt_mem_next_cell(int s, const __be32 **cellp);
>
>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
prev parent reply other threads:[~2021-10-25 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 16:46 [PATCH] x86: of: Kill unused early_init_dt_scan_chosen_arch() Rob Herring
2021-10-25 4:26 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3013783-b5b6-6a60-17c1-4bd65004dd5e@gmail.com \
--to=frowand.list@gmail.com \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).