From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nischal, Amit" Subject: Re: [PATCH 2/2] clk: qcom: Add video clock controller driver for SDM845 Date: Wed, 2 May 2018 13:26:35 +0530 Message-ID: References: <1524576771-31096-1-git-send-email-anischal@codeaurora.org> <1524576771-31096-3-git-send-email-anischal@codeaurora.org> <152521087780.138124.7623601052057968460@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <152521087780.138124.7623601052057968460@swboyd.mtv.corp.google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd , Michael Turquette , Stephen Boyd Cc: Andy Gross , David Brown , Rajendra Nayak , Odelu Kukatla , Taniya Das , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 5/2/2018 3:11 AM, Stephen Boyd wrote: > Quoting Amit Nischal (2018-04-24 06:32:51) >> Add support for the video clock controller found on SDM845 >> based devices. This would allow video drivers to probe and >> control their clocks. >> >> Signed-off-by: Amit Nischal > Driver looks small and good. Only concern is that there aren't resets > defined, but the binding says there are resets. Will you add them? Thanks for the review. As of now, there are no resets defined for VIDEOCC. So I will move the #reset-cells tooptional property in the dt-binding. Same will be updated in the next patch series. > > I'm going to wait for the respin on the dts binding anyway. Yes, I will send the next patch series soon. > -- > To unsubscribe from this list: send the line "unsubscribe linux-clk" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html