From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ramona Bolboaca <ramona.bolboaca@analog.com>,
jic23@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] bindings: iio: adc: Add max11205 documentation file
Date: Wed, 31 Aug 2022 16:36:25 +0300 [thread overview]
Message-ID: <d33607e2-42de-ac4e-7ed0-4c25504ac092@linaro.org> (raw)
In-Reply-To: <20220831133021.215625-1-ramona.bolboaca@analog.com>
On 31/08/2022 16:30, Ramona Bolboaca wrote:
> Add bindings documentation file and MAINTAINERS entry for MAX11205.
>
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@analog.com>
> +properties:
> + compatible:
> + enum:
> + - maxim,max11205a
> + - maxim,max11205b
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 5000000
> +
> + spi-cpha: true
> +
> + vref-supply:
> + description:
> + The regulator supply for the ADC reference voltage. This is a differential
> + reference. It is equal to the V_REFP - V_REFN. The maximum value is 3.6V.
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> + - spi-cpha
> + - interrupts
> + - vref-supply
If you are going to send a new version, please put the properties here
in the same order as they appear in top-level "properties:".
In any case:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-31 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 13:30 [PATCH v2 1/2] bindings: iio: adc: Add max11205 documentation file Ramona Bolboaca
2022-08-31 13:30 ` [PATCH v2 2/2] iio: adc: add max11205 adc driver Ramona Bolboaca
2022-08-31 20:20 ` Andy Shevchenko
2022-09-01 8:04 ` Bolboaca, Ramona
2022-09-04 15:37 ` Jonathan Cameron
2022-09-04 15:50 ` Jonathan Cameron
2022-09-04 15:51 ` Jonathan Cameron
2022-09-04 19:49 ` Andy Shevchenko
2022-08-31 13:36 ` Krzysztof Kozlowski [this message]
2022-09-04 15:44 ` [PATCH v2 1/2] bindings: iio: adc: Add max11205 documentation file Jonathan Cameron
2022-09-04 15:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d33607e2-42de-ac4e-7ed0-4c25504ac092@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).