From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>, Conor Dooley <conor@kernel.org>
Cc: "Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Macpaul Lin" <macpaul.lin@mediatek.com>,
"Sean Wang" <sean.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-makomo
Date: Wed, 25 Oct 2023 16:54:48 +0200 [thread overview]
Message-ID: <d33bf9c9-b6a6-42aa-acc7-675b2c7aa1f9@linaro.org> (raw)
In-Reply-To: <CAJMQK-hvhjNGFUfgqb7pm=pAYjJ0wZAhkPGXxDCUJ5cnUDh2gw@mail.gmail.com>
On 24/10/2023 20:22, Hsin-Yi Wang wrote:
> On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@kernel.org> wrote:
>>
>> On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote:
>>> Add makomo sku0 and sku1 which uses different audio codec.
>>>
>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>> ---
>>> Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> index fe8c488a3207..b131e0bdbf01 100644
>>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> @@ -250,6 +250,18 @@ properties:
>>> - google,kodama-sku32
>>> - const: google,kodama
>>> - const: mediatek,mt8183
>>> + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
>>> + items:
>>> + - const: google,makomo-rev4-sku0
>>> + - const: google,makomo-rev5-sku0
>>
>> With these bindings, how does one describe a makomo-rev5-sku0?
>> What you have here is only suitable for describing the makomo-rev4-sku0.
>>
> makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts:
>
> compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0",
> "google,makomo", "mediatek,mt8183";
>
> In this case, can bindings be listed like that?
If they use the same DTS, then I would expect rev5 (as newer model, more
specific) followed by rev4 (older).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-25 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 0:02 [PATCH 0/6] Add a few mt8183 follower boards Hsin-Yi Wang
2023-10-24 0:02 ` [PATCH 1/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-katsu Hsin-Yi Wang
2023-10-24 15:15 ` Conor Dooley
2023-10-24 19:46 ` Hsin-Yi Wang
2023-10-24 0:02 ` [PATCH 2/6] arm64: dts: mt8183: Add kukui katsu board Hsin-Yi Wang
2023-10-24 0:02 ` [PATCH 3/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-makomo Hsin-Yi Wang
2023-10-24 15:17 ` Conor Dooley
2023-10-24 18:22 ` Hsin-Yi Wang
2023-10-25 14:49 ` Conor Dooley
2023-10-25 19:33 ` Hsin-Yi Wang
2023-10-25 14:54 ` Krzysztof Kozlowski [this message]
2023-10-24 0:02 ` [PATCH 4/6] arm64: dts: mt8183: Add jacuzzi makomo board Hsin-Yi Wang
2023-10-24 15:22 ` Krzysztof Kozlowski
2023-10-24 0:02 ` [PATCH 5/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-pico Hsin-Yi Wang
2023-10-24 15:13 ` Conor Dooley
2023-10-24 0:02 ` [PATCH 6/6] arm64: dts: mt8183: Add jacuzzi pico/pico6 board Hsin-Yi Wang
2023-10-24 15:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d33bf9c9-b6a6-42aa-acc7-675b2c7aa1f9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bero@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).