From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD58AC77B75 for ; Mon, 8 May 2023 10:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234679AbjEHK2y (ORCPT ); Mon, 8 May 2023 06:28:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234530AbjEHK2g (ORCPT ); Mon, 8 May 2023 06:28:36 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74CEFD2E7 for ; Mon, 8 May 2023 03:28:34 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2ac836f4447so41752241fa.2 for ; Mon, 08 May 2023 03:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683541712; x=1686133712; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I2Jb+xA8QGd1sVsf3f5607mlfCv/gv10lcVV2z3QNTI=; b=f3mTLwEfdvUiXjDcEzJ3Z+m0bt6D1IXVPzbEtXDvgGVP8nekC+GD6PIenAt/TlLgce 7u+B2bdtASR6O3VIlfVzmZdwasDY0VeReTexR9/I99aZMqVmyNiajsrkXUSjmUelJ6YW DHOIahsjXRerPO2EI/l48ZlYZAgxIbNsJTLrowmfF2ryvWoO5mMMMCzcj1FHM4UN75G0 UQM3BHRCT5azEWlgwHGX3AH2P+VSlQbyhLYztdRJPXu5DgA275k+XoFR+fO4ayCbU17I oreSPnESoyGzDalguQee8j0QVdjCkufWkMm96h41vZKX7eP5wodoGRadQfoMIU1b/xE+ H46w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683541712; x=1686133712; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I2Jb+xA8QGd1sVsf3f5607mlfCv/gv10lcVV2z3QNTI=; b=UTm9DP06rvKn9B6gwukg2eT2pkVqognl5ZF6wrcDWAcnF4rx+sxAW95/Ga9ib9ojtO Eg0fa3yxqAmt9C6e5Faj+BkguCSw6sFJp26RXzvc1rxo7tAxBrixVKgolVaxQe+yGBi1 R70pb4jm/I4372K8iCiObZVKwIy9YUCLf9WfJOueTk+w4ht9VArdf5LxanINkaNbX3fC 3RebuvZUJ0T6IuvGIfEJto54hcNfP8juDNj/Tdb5t6jJpwwWx70IPkeSZm9fvthlDlOI PxvFWA04gZFoACQQXMWLVXHN0x2VK2QTDSUMmSKcCIXlmKRjhasDIRzt0F/AcANYy4F+ yAwQ== X-Gm-Message-State: AC+VfDzoRsM30F3UMiSQp5nd3P0QJklid/fAs0EooK4RSbYlK8j/aCNS q9Jgz6AtmPSnQAAIt+vbBUPxz6SL7mwlU6AXRlI= X-Google-Smtp-Source: ACHHUZ4h0seTe4/zh3HmwznORxKSXd7UYJS5RgdNNFU0wGGRhLw3cbZnlmYxmIDSQ1Nw4afv8SwzXQ== X-Received: by 2002:a2e:2419:0:b0:2ad:85dd:f3a8 with SMTP id k25-20020a2e2419000000b002ad85ddf3a8mr1287361ljk.30.1683541712491; Mon, 08 May 2023 03:28:32 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id p19-20020a2e9a93000000b002ad94c4351asm241662lji.66.2023.05.08.03.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 03:28:32 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 12:28:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20230507190735.2333145-1-dmitry.baryshkov@linaro.org> <20230507190735.2333145-2-dmitry.baryshkov@linaro.org> <8cdecc51-2a42-4b82-9eb3-2ab77860c5d4@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8.05.2023 12:24, Dmitry Baryshkov wrote: > On 08/05/2023 11:30, Konrad Dybcio wrote: >> >> >> On 7.05.2023 21:07, Dmitry Baryshkov wrote: >>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be >>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. >>> >>> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support") >>> Signed-off-by: Dmitry Baryshkov >>> --- >> Uhh.. this clock should be managed by RPM with: >> >> type = MEM >> id = 2 >> >> just like it's defined for 8994 today. >> >> Could you try adding it in rpmcc and confirming? > > There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the ocmemnoc. It's wrong. Konrad > >> >> Konrad >>>   arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi >>> index 834ad95515b1..fb661c1bd3d5 100644 >>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi >>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi >>> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 { >>>                 clocks = <&mmcc OXILI_GFX3D_CLK>, >>>                    <&mmcc OXILICX_AHB_CLK>, >>> +                 <&mmcc OXILI_OCMEMGX_CLK>, >>>                    <&mmcc OXILICX_AXI_CLK>; >>> -            clock-names = "core", "iface", "mem_iface"; >>> +            clock-names = "core", "iface", "mem", "mem_iface"; >>>                 sram = <&gmu_sram>; >>>               power-domains = <&mmcc OXILICX_GDSC>; >