devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Taniya Das <quic_tdas@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Abhishek Sahu <absahu@codeaurora.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Ajit Pandey <quic_ajipan@quicinc.com>,
	Imran Shaik <quic_imrashai@quicinc.com>,
	Jagadeesh Kona <quic_jkona@quicinc.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver
Date: Sat, 19 Oct 2024 01:38:50 +0100	[thread overview]
Message-ID: <d3658f34-c24a-47c4-a8fc-989de009b4fb@linaro.org> (raw)
In-Reply-To: <f5exjvacw4gz7s7byxz6aux7jt3kczn5waio3f3dukpdvzmkvi@c65xjssv4aqy>

On 18/10/2024 21:22, Dmitry Baryshkov wrote:
>> +static struct gdsc ife_1_gdsc = {
>> +	.gdscr = 0xa004,
>> +	.en_rest_wait_val = 0x2,
>> +	.en_few_wait_val = 0x2,
>> +	.clk_dis_wait_val = 0xf,
>> +	.pd = {
>> +		.name = "ife_1_gdsc",
>> +	},
>> +	.pwrsts = PWRSTS_OFF_ON,
>> +	.flags = POLL_CFG_GDSCR,
>> +};
> Shouldn't IFE GDSCs have titan_top as a parent?

Ack, usually, this looks wrong.

---
bod

  reply	other threads:[~2024-10-19  0:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 19:15 [PATCH 00/11] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform Taniya Das
2024-10-18 19:15 ` [PATCH 01/11] clk: qcom: Update the support for alpha mode configuration Taniya Das
2024-10-18 20:06   ` Dmitry Baryshkov
2024-10-21 19:50   ` Gabor Juhos
2024-10-18 19:15 ` [PATCH 02/11] clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs Taniya Das
2024-10-18 20:20   ` Christophe JAILLET
2024-10-30 17:52     ` Taniya Das
2024-10-18 19:15 ` [PATCH 03/11] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller Taniya Das
2024-10-22  6:01   ` Krzysztof Kozlowski
2024-10-30 17:53     ` Taniya Das
2024-10-18 19:15 ` [PATCH 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver Taniya Das
2024-10-18 20:19   ` Dmitry Baryshkov
2024-10-30 17:54     ` Taniya Das
2024-10-18 20:22   ` Dmitry Baryshkov
2024-10-19  0:38     ` Bryan O'Donoghue [this message]
2024-10-30 17:56     ` Taniya Das
2024-10-18 19:15 ` [PATCH 05/11] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller Taniya Das
2024-10-18 20:33   ` Rob Herring (Arm)
2024-10-18 19:15 ` [PATCH 06/11] clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver Taniya Das
2024-10-18 20:25   ` Dmitry Baryshkov
2024-10-30 17:58     ` Taniya Das
2024-10-31 15:12       ` Dmitry Baryshkov
2024-10-18 19:15 ` [PATCH 07/11] dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller Taniya Das
2024-10-18 20:33   ` Rob Herring (Arm)
2024-10-18 19:15 ` [PATCH 08/11] clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver Taniya Das
2024-10-18 20:28   ` Dmitry Baryshkov
2024-10-30 18:03     ` Taniya Das
2024-10-31 15:14       ` Dmitry Baryshkov
2024-11-01  7:15         ` Taniya Das
2024-11-01  7:51           ` Dmitry Baryshkov
2024-10-18 19:15 ` [PATCH 09/11] dt-bindings: clock: Add Qualcomm QCS615 Video clock controller Taniya Das
2024-10-18 20:33   ` Rob Herring (Arm)
2024-10-18 19:15 ` [PATCH 10/11] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver Taniya Das
2024-10-18 20:31   ` Dmitry Baryshkov
2024-10-30 18:04     ` Taniya Das
2024-10-18 19:15 ` [PATCH 11/11] arm64: defconfig: Enable QCS615 clock controllers Taniya Das
2024-10-18 20:32   ` Dmitry Baryshkov
2024-10-30 18:05     ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3658f34-c24a-47c4-a8fc-989de009b4fb@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=absahu@codeaurora.org \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sboyd@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).