From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59EBF1922E3 for ; Sat, 19 Oct 2024 00:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729298337; cv=none; b=Ik4BEkoXe4AEd1tJgqTrUXjcgZ+45NmtqWNhiKYZanBx2lvJhNvAupACs30VtPYJn+yj2/t4lkjn50lob2sna+bbSapEwA0FAUN+GFQ1PzQoeNxmd3svnqj7X6svSu32mkNXATIM45MtuDz+AkO9ZWwgSEmrkMFDPRELn98Cod8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729298337; c=relaxed/simple; bh=Mewcl59dRlGPPCpRuSRwPywr6ycIDIWaUH/SfdWIQ8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=omID6e3kTkr+bblO+UgKsTNORUg0/vVl8Ssnl/CLC+lP+056xBHkNOc9fZ+eh3k37EEQIUKo6bAoXeMRwpMClIaOSKczho5AyatQ23BNVrSzSzTYsxDHMkWn408Icz1Y/iRXUqBNKUBF4wuVPISjB9Svyb/zGbfT962dpiZPG48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u2Se86gg; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u2Se86gg" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-539f0f9ee49so3095851e87.1 for ; Fri, 18 Oct 2024 17:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729298333; x=1729903133; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0M41lobMzDtVDXSER1bmN9AsQKoidShYGX+Z+FE6IRg=; b=u2Se86ggxXhSy3+mSEOGZxWNPamUQzT3i6si7Xi+iBE6XsK1OlkAoS8qvkiBybH5fg rB/wEn+Q1KalHsEHGQPAJX+LcR38Wqcp8jor1kRV4/8ZhzIa7n5Bdae6mKFeVblPD7zL 6fs2jb98Rcjnyxmgwz4eMK0I4gPvILYgD9U0eW81HDkVzIB7P9PHAAWX7l6adRATkaOf c/cjJ2VCZlU2VYEAKiunx/Taf8g62Kgod9fME1P92PuyTiCmh2Ftk3Y0iKrV/6DKsn9U OCM4Q2Qgw/gVkIwwyqQXi0NEmpW9zSLgAMuL7qH39bWwCjHNjvrSjYxPKetTd2TLh7Iy VHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729298333; x=1729903133; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0M41lobMzDtVDXSER1bmN9AsQKoidShYGX+Z+FE6IRg=; b=vN+srni6GHs1/ry7jXUvHYLW7yRBMPQMisnBQOxxXHdKmvOLMwHi94uVWH6jw6qCkX O3m4NhquFVVMX/3gGNtOQheGew0bf6bxMgEPA/F+kaG/FlfGrmsKkhVHNp7gQP5LwM9z b41NLyo8BpEcpvDMx/ngKDrl8l+8Hyp1egrB53sj0d528s3cueNH8abXsASD9L2Tu7SO kHSYJ28x5hZXC82qLgy3rQEeQVwpofYZI2ozWG+SYPqj/9GYQ6bPwOB9dYllogwvAm7p lilhkTeI+7d17Nv8nPkXzMDyPRSs8S5/C5iJQu3bh7MZGutSNNaFvYNTbCjc2npQJGSh 5oKg== X-Forwarded-Encrypted: i=1; AJvYcCVMEEGYxL0Wlx2X2M6KgYqzOynGyv4rb/b5dmOduUaVGpusce8Xzf3oxpAQ0hxcg5A3gJdrjklCIu9K@vger.kernel.org X-Gm-Message-State: AOJu0YxwyySp6mNgSot/cKLDvPS3nUqqE6skxPKu7coRzSbE/3BoU++l RxwqBTE13cJsrFQA/5O9749lqA3V+l0EIsHJOolTc5uE0L3mSpyJXR6MpnTgyw8= X-Google-Smtp-Source: AGHT+IF7fBEeWmNkccNzd31LUcjDvOyf3yMzraYUGO6AugKRPwkcFosfUe4YdEuEFjihSL5BW7Y+2g== X-Received: by 2002:a05:6512:4009:b0:52c:fd46:bf07 with SMTP id 2adb3069b0e04-53a154ce86amr3097967e87.49.1729298333228; Fri, 18 Oct 2024 17:38:53 -0700 (PDT) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ca0b076d0asm1272577a12.16.2024.10.18.17.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2024 17:38:52 -0700 (PDT) Message-ID: Date: Sat, 19 Oct 2024 01:38:50 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver To: Dmitry Baryshkov , Taniya Das Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Abhishek Sahu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Ajit Pandey , Imran Shaik , Jagadeesh Kona , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20241019-qcs615-mm-clockcontroller-v1-0-4cfb96d779ae@quicinc.com> <20241019-qcs615-mm-clockcontroller-v1-4-4cfb96d779ae@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/10/2024 21:22, Dmitry Baryshkov wrote: >> +static struct gdsc ife_1_gdsc = { >> + .gdscr = 0xa004, >> + .en_rest_wait_val = 0x2, >> + .en_few_wait_val = 0x2, >> + .clk_dis_wait_val = 0xf, >> + .pd = { >> + .name = "ife_1_gdsc", >> + }, >> + .pwrsts = PWRSTS_OFF_ON, >> + .flags = POLL_CFG_GDSCR, >> +}; > Shouldn't IFE GDSCs have titan_top as a parent? Ack, usually, this looks wrong. --- bod