From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF54312E40 for ; Sun, 14 Jul 2024 13:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720964788; cv=none; b=Ofbvl3PmGaTu49N4Ml6mA1dgGq2m6hFuKjc3J1fpOy02IJwcYJG60JlJUP1t2wkR5Cl0D1lkvto9mMRWgHqzVs8Se0e2VH4fDnO0nl3ogT2jjtxhrnC3JBwFm7RBt4lWXwYsIwT4ACUGXoY0SDeP2cnIoGCHXU06Q9BAZz8xDIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720964788; c=relaxed/simple; bh=tRZclaax6e/MHDoRUK0Pc2UvrR9AorgQuTds3t4McLM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=bymAG3erbyhaSOT9n376FTfe6GUSrJxxGLKce/gwVaYIvTQxEkAI1556teHv5Q7zYb0NdRaa0HnWjHbh23hkUdUxXC8LHaM9+oyAf9SEEx7RlAahcu+N2Enu8dOVCujKg0U2KGFXvieVta3KLyLh1eutwdxJnI38aDrm54FDJDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=FGAqJGiF; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="FGAqJGiF" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4266fd395eeso23568345e9.3 for ; Sun, 14 Jul 2024 06:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1720964785; x=1721569585; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XhhF2kOObaWSpTUE3FHoWYSAyXxA8qZtiRUXKka5xPk=; b=FGAqJGiFRIkV1MTO7xrPDj+2GSxiYWiIRNt4kXX1BP/GWoMGIde4SDZHrRyBEm/Bx2 BZuyuWtKZuatTYg7nTrCBO3sKpFgFcPD0mnR0BMDVMj/HwdkUR9CiB6tWeIrr+x4ydVy bExnjGgBGVT+6pNOeT1xoPDFmrrnDEgcX6hZPJj4iwlaAhIuo/BpWcRgHyNTjcEQgfrJ T16zNLWEbXgosKNdVSxhi7OKbC8uQtC/6DWmJ1RNNDRUJEDlO+gJV9GG0zNRG+6x0vR1 +dLH+1uQpWhIdgeGf3d0hw+niXVgFGzskQiOaNGld55OK6xJyRIR49EZiUCMIsphKBSl 6ImA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720964785; x=1721569585; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XhhF2kOObaWSpTUE3FHoWYSAyXxA8qZtiRUXKka5xPk=; b=MPdihDMio8IuORIuQ3hDuDRP0p0ypSiixhyYLrw2CIR96AxYoZb5Ov+tBiP5nOGY1H fygNI9v31uaatePEtj/ylKW5RPCpj9YI2bIyn6GW6DZGsBJaDEq4AuWpyi+bcdx3Y5Sm gWJ0Y17OfhuaCyaet9kOdqpB5n7xVsj5gk16PMknRSqvmT5c9c2TnBGz5rYyiqjalRMb PwQfMrzrp2jbjlTDvTKhrW/czr4OKGudPNAxrdB3PNZx0uFZDPIuEFBAwp8VjGYcoCAU DnN6tMCtt/5Nmx/8SBV4EP2Ps6Qa89TSyN7ia3/prkKQFIiksfdPYD5UxyYj7miFEhIA w6+A== X-Forwarded-Encrypted: i=1; AJvYcCW2WlGmoIUyXEVSJgiKTgHQ8iLz9FA4nfb9mZF9N14JQHFx82PxC8S81BohlGwkehIFbTydAncmkzaNL8+iiLYvZIn3OyQAjSfioQ== X-Gm-Message-State: AOJu0Yz2npqgaFuJ/dGM2hvh/hx349fLgQeAcyri13EhuxttCJhrQZwx wq885BuJ8izzX4qDMIvff07hJF8xlwkch81ny0ErwwYfgRHrlZIOb28Eu5SwCBs= X-Google-Smtp-Source: AGHT+IF00EL0Y03INAlv8YUqpJscKmmaNb+dyxPLgyZMXltbvzpjzs9gZweXVagxn0t14s0u9qa2RA== X-Received: by 2002:a05:600c:3042:b0:426:6a5e:73c5 with SMTP id 5b1f17b1804b1-426708f1035mr104521085e9.37.1720964784947; Sun, 14 Jul 2024 06:46:24 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5ef550asm52187375e9.46.2024.07.14.06.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jul 2024 06:46:24 -0700 (PDT) Message-ID: Date: Sun, 14 Jul 2024 16:46:23 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 27/27] ARM: dts: microchip: sam9x75_curiosity: add sam9x75 curiosity board Content-Language: en-US To: Varshini Rajendran , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, mihai.sain@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240703102011.193343-1-varshini.rajendran@microchip.com> <20240703102943.196655-1-varshini.rajendran@microchip.com> From: claudiu beznea In-Reply-To: <20240703102943.196655-1-varshini.rajendran@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Varshini, On 03.07.2024 13:29, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran > --- > Changes in v5: > - Update commit message to match the directory structure. > - Alphanumerically sorted Makefile entries. > - Corrected VDDCore minimum voltage. > - Enabled the i2s node. > - Removed additional blank lines. > - Enclosed each entry with separate <>. > - Corrected pinctrl names to match Microchip convention. > - Enabled slewrate in sdmmc node. > - Corrected pinmux mask. > - Added phandle to leds for ease of access with upcoming device entries. > - Updated gpio pin number for red led. > --- > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sam9x75_curiosity.dts | 312 ++++++++++++++++++ > 2 files changed, 315 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index 0c45c8d17468..470fe46433a9 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -2,6 +2,7 @@ > # Enables support for device-tree overlays > DTC_FLAGS_at91-sam9x60_curiosity := -@ > DTC_FLAGS_at91-sam9x60ek := -@ > +DTC_FLAGS_at91-sam9x75_curiosity := -@ > DTC_FLAGS_at91-sama5d27_som1_ek := -@ > DTC_FLAGS_at91-sama5d27_wlsom1_ek := -@ > DTC_FLAGS_at91-sama5d29_curiosity := -@ > @@ -60,6 +61,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..4a4f14f13634 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > @@ -0,0 +1,312 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + led_red: led-red { > + label = "red"; > + gpios = <&pioC 14 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&pinctrl_red_led_gpio_default>; > + }; > + > + led_green: led-green { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&pinctrl_green_led_gpio_default>; > + }; > + > + led_blue: led-blue { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&pinctrl_blue_led_gpio_default>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + reg = <0x20000000 0x10000000>; > + device_type = "memory"; > + }; > +}; > + > +&classd { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_classd_default>; > + atmel,pwm-type = "diff"; > + atmel,non-overlap-time = <10>; > + status = "okay"; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu_default>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = ; > + status = "okay"; > +}; > + > +&i2c6 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; > + > + pmic@5b { > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddioddr: VDD_DDR { > + regulator-name = "VDD_DDR"; > + regulator-min-microvolt = <1283000>; > + regulator-max-microvolt = <1450000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddcore: VDD_CORE { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <1140000>; > + regulator-max-microvolt = <1210000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddcpu: VDD_OTHER { > + regulator-name = "VDD_OTHER"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3600000>; I haven't got any input on question asked in v4 on the regulator values. Are the values from this version the right ones? Is this board supporting DVFS or the label name is wrong or maybe the min-max range is still wrong? > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-ramp-delay = <3125>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + > + vldo2: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + }; > + }; > +}; > + > +&i2s { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s_default>; > + #sound-dai-cells = <0>; > + status = "okay"; > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&pinctrl { > + classd { > + pinctrl_classd_default: classd-default { > + atmel,pins = > + , > + ; > + }; > + }; > + > + dbgu { > + pinctrl_dbgu_default: dbgu-default { > + atmel,pins = , > + ; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6-default { > + atmel,pins = > + , > + ; > + }; > + }; > + > + gpio-keys { > + pinctrl_key_gpio_default: key-gpio-default { > + atmel,pins = ; > + }; > + }; > + > + i2s { > + pinctrl_i2s_default: i2s-default { > + atmel,pins = > + , /* I2SCK */ > + , /* I2SWS */ > + , /* I2SDIN */ > + , /* I2SDOUT */ > + ; /* I2SMCK */ > + }; > + }; > + > + leds { > + pinctrl_red_led_gpio_default: red-led-gpio-default { > + atmel,pins = ; > + }; > + pinctrl_green_led_gpio_default: green-led-gpio-default { > + atmel,pins = ; > + }; > + pinctrl_blue_led_gpio_default: blue-led-gpio-default { > + atmel,pins = ; > + }; > + }; > + > + sdmmc0 { > + pinctrl_sdmmc0_default: sdmmc0-default { > + atmel,pins = > + , /* PA2 CK periph A with pullup */ > + , /* PA1 CMD periph A with pullup */ > + , /* PA0 DAT0 periph A */ > + , /* PA3 DAT1 periph A with pullup */ > + , /* PA4 DAT2 periph A with pullup */ > + ; /* PA5 DAT3 periph A with pullup */ > + }; > + }; > +}; /* pinctrl */ > + > +&rtt { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > + > +&sdmmc0 { > + bus-width = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc0_default>; > + cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > + disable-wp; > + status = "okay"; > +}; > + > +&slow_xtal { > + clock-frequency = <32768>; > +}; > + > +&poweroff { > + debounce-delay-us = <976>; > + status = "okay"; > + > + input@0 { > + reg = <0>; > + }; > +}; > + > +&trng { > + status = "okay"; > +}; > + > +&watchdog { > + status = "okay"; > +};