Devicetree
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: dts: socfpga: Add basic support for Terrasic's de10-nano
Date: Thu, 30 Jan 2025 13:59:10 +0100	[thread overview]
Message-ID: <d375f621-1502-419e-bb99-658ca2fd2b63@lunn.ch> (raw)
In-Reply-To: <20250130074553.92023-2-u.kleine-koenig@baylibre.com>

> +&gmac1 {
> +	/* Uses a KSZ9031RNX phy */
> +	phy-mode = "rgmii-id";
> +	rxd0-skew-ps = <420>;
> +	rxd1-skew-ps = <420>;
> +	rxd2-skew-ps = <420>;
> +	rxd3-skew-ps = <420>;
> +	txen-skew-ps = <0>;
> +	rxdv-skew-ps = <420>;
> +	status = "okay";
> +};


For this part:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Thanks for making the change.

    Andrew

  parent reply	other threads:[~2025-01-30 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  7:45 [PATCH v2] ARM: dts: socfpga: Add basic support for Terrasic's de10-nano Uwe Kleine-König
2025-01-30  8:46 ` Krzysztof Kozlowski
2025-01-30 12:59 ` Andrew Lunn [this message]
2025-01-30 23:38 ` Rob Herring (Arm)
2025-01-31 16:47   ` Uwe Kleine-König
2025-01-31 21:28     ` Krzysztof Kozlowski
2025-01-31 21:30       ` Krzysztof Kozlowski
2025-02-03 11:39       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d375f621-1502-419e-bb99-658ca2fd2b63@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox