From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Tiezhu Yang <yangtiezhu@loongson.cn>,
Marc Zyngier <maz@kernel.org>,
Youling Tang <tangyouling@loongson.cn>,
Baoqi Zhang <zhangbaoqi@loongson.cn>,
Arnd Bergmann <arnd@arndb.de>, Yun Liu <liuyun@loongson.cn>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v1 2/3] dt-bindings: soc: add loongson-2 pm
Date: Wed, 17 May 2023 17:00:24 +0200 [thread overview]
Message-ID: <d3791702-4d41-0208-1346-34738a2883b6@linaro.org> (raw)
In-Reply-To: <20230517073149.31980-3-zhuyinbo@loongson.cn>
On 17/05/2023 09:31, Yinbo Zhu wrote:
> Add the Loongson-2 SoC Power Management Controller binding with DT
> schema format using json-schema.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
...
> +properties:
> + compatible:
> + items:
> + - enum:
> + - loongson,ls2k-pmc
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + suspend-address:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + This option indicate this PM suspend address.
This tells me nothing. Drop "This option indicate this" and rephrase
everything to actually describe this property. Why would the address
differ on given, specific SoC? It looks like you just miss compatibles.
Anyway this needs much more explanation so we can judge whether it fits DT.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + pmc: pm@1fe27000 {
> + compatible = "loongson,ls2k-pmc", "syscon";
> + reg = <0x1fe27000 0x58>;
> + interrupt-parent = <&liointc1>;
> + interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + suspend-address = <0x1c000500>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-17 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 7:31 [PATCH v1 0/3] soc: loongson2_pm: add power management support Yinbo Zhu
2023-05-17 7:31 ` [PATCH v1 1/3] loongarch: export loongarch pm interface Yinbo Zhu
2023-05-17 7:31 ` [PATCH v1 2/3] dt-bindings: soc: add loongson-2 pm Yinbo Zhu
2023-05-17 15:00 ` Krzysztof Kozlowski [this message]
2023-05-18 3:23 ` zhuyinbo
2023-05-18 7:15 ` Krzysztof Kozlowski
2023-05-18 12:15 ` zhuyinbo
2023-05-18 14:15 ` Krzysztof Kozlowski
2023-05-19 6:52 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3791702-4d41-0208-1346-34738a2883b6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=liuyun@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=maz@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tangyouling@loongson.cn \
--cc=wanghongliang@loongson.cn \
--cc=yangtiezhu@loongson.cn \
--cc=zhangbaoqi@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).