From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA1ADC77B7D for ; Wed, 17 May 2023 15:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbjEQPC2 (ORCPT ); Wed, 17 May 2023 11:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232469AbjEQPBv (ORCPT ); Wed, 17 May 2023 11:01:51 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8C31A5C7 for ; Wed, 17 May 2023 08:00:38 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-510bcd2d6b8so7061986a12.0 for ; Wed, 17 May 2023 08:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684335627; x=1686927627; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u1G2m3/V/8HwP4S0PilYqw+ntJ6wrr0IYdjxDwg97nI=; b=KGGwf+TgQE3MnRRbh8F9ZWrd7mAnUM8CGnhjLSRzEP7eBdZtDzGG8r9cH15QPidrTY yNGdaoRLij2m2vk4yF9wQ3wdwVDhXg4ZKccA5K6j9U3lRc/r/vfo+iflvGfjQCIfce0s SpLcDsgxsiGJL1KfSZWdYCfPprlt0QjnmOVxFI6UAmoWosvoa6scXeFec1MUvbqFhhA2 QtoY0wUfTxjbVwxaZQ5TtE79S8Rbp+jvbwanrUIFKLrlpkjUwk3WshLMR+18gmvifTFs kNhjU1v1QwAba8Umv1KoaJRvXo2IZUYVBC11kMyEb/TjWc+uzI6MYel0w8b3ANUkt4pR foYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684335627; x=1686927627; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u1G2m3/V/8HwP4S0PilYqw+ntJ6wrr0IYdjxDwg97nI=; b=JodqRZqDFU8v6uCw6/vp33loUt5r276JehKCkQRF9G638P6go2zuw2UlDh6Nd+VYW1 VrhZFc+ycY+yBssleQjdl11bjNiWX1z/eGKl97bymUgjLPaHjE7ldmb/Prxv+Fg8T/Rp 1+aocQByv6Farm8Wf9ccYnKFekYAX+iHG5189rUS5h891GSCdm7GlRGjxfCnB1TxZAZp qod3tttLAG/4AA8ICzXLv1CqyxVguPYRf4hqFIBP4r3Orh2VCydMjZnsxmZxMQjFhSRN uAyaECWbtmjIdbrzsOeK2WAwzk9Zrtrt+ItgiIdpENBkwOcFnrB/E1PLvicWddPrdNc4 9AdA== X-Gm-Message-State: AC+VfDxW7gHzU0DSmtptUU3jUZd54462zBH3WAsF7i1KOE6KYcvMls+m rCLExNBDOM6RKd1C3FqNKMkB0A== X-Google-Smtp-Source: ACHHUZ6wgsqOiRJf4xmcSwbV6QggqmsGx/cjJKJNST88Bdd9lOPCs5cSMTYn0pICtw84HRJnXKbqFA== X-Received: by 2002:a17:907:d21:b0:94a:57d1:5539 with SMTP id gn33-20020a1709070d2100b0094a57d15539mr2566510ejc.5.1684335626891; Wed, 17 May 2023 08:00:26 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c9ff:4c84:dd21:568d? ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id bm11-20020a170906c04b00b00965ec1faf27sm12391114ejb.74.2023.05.17.08.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 08:00:26 -0700 (PDT) Message-ID: Date: Wed, 17 May 2023 17:00:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 2/3] dt-bindings: soc: add loongson-2 pm Content-Language: en-US To: Yinbo Zhu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Huacai Chen , WANG Xuerui , "Rafael J . Wysocki" , Pavel Machek , Tiezhu Yang , Marc Zyngier , Youling Tang , Baoqi Zhang , Arnd Bergmann , Yun Liu , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230517073149.31980-1-zhuyinbo@loongson.cn> <20230517073149.31980-3-zhuyinbo@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <20230517073149.31980-3-zhuyinbo@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/05/2023 09:31, Yinbo Zhu wrote: > Add the Loongson-2 SoC Power Management Controller binding with DT > schema format using json-schema. > > Signed-off-by: Yinbo Zhu ... > +properties: > + compatible: > + items: > + - enum: > + - loongson,ls2k-pmc > + - const: syscon > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + suspend-address: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + This option indicate this PM suspend address. This tells me nothing. Drop "This option indicate this" and rephrase everything to actually describe this property. Why would the address differ on given, specific SoC? It looks like you just miss compatibles. Anyway this needs much more explanation so we can judge whether it fits DT. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + pmc: pm@1fe27000 { > + compatible = "loongson,ls2k-pmc", "syscon"; > + reg = <0x1fe27000 0x58>; > + interrupt-parent = <&liointc1>; > + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > + suspend-address = <0x1c000500>; Best regards, Krzysztof