From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Gerlach, Matthew" <matthew.gerlach@altera.com>,
Rob Herring <robh@kernel.org>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, dinguyen@kernel.org,
bp@alien8.de, tony.luck@intel.com, james.morse@arm.com,
mchehab@kernel.org, rric@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: agilex: Update eccmgr in DTSI to reflect hw/yaml
Date: Fri, 21 Mar 2025 08:46:43 +0100 [thread overview]
Message-ID: <d37eb60d-fd84-4274-85ac-6ddfd32de3a5@kernel.org> (raw)
In-Reply-To: <3b325b3b-df64-4f16-9284-cddfaaa40a21@altera.com>
On 21/03/2025 00:24, Gerlach, Matthew wrote:
>
> On 3/20/2025 12:34 PM, Rob Herring wrote:
>> On Thu, Mar 20, 2025 at 09:46:21AM -0700, Matthew Gerlach wrote:
>>> Update socfpga_agilex.dtsi to track the actual hardware description
>>> provided in altr,socfpga-s10-ecc-manager.yaml.
>>>
>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
>>> ---
>>> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 18 ++++++------------
>>> 1 file changed, 6 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
>>> index 1235ba5a9865..708cb8e762b6 100644
>>> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
>>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
>>> @@ -602,8 +602,7 @@ sdr: sdr@f8011100 {
>>> };
>>>
>>> eccmgr {
>>> - compatible = "altr,socfpga-s10-ecc-manager",
>>> - "altr,socfpga-a10-ecc-manager";
>>> + compatible = "altr,socfpga-s10-ecc-manager";
>>
>> You are breaking the ABI here. Before this series, the driver required
>> altr,socfpga-a10-ecc-manager.
> Yes, breaking the ABI required the change in PATCH 2/4, which is
> suboptimal.
It's still ABI break for no good reason.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-21 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 16:46 [PATCH 0/4] dt-bindings: edac: altera-s10: Convert to YAML Matthew Gerlach
2025-03-20 16:46 ` [PATCH 1/4] " Matthew Gerlach
2025-03-20 19:27 ` Rob Herring
2025-03-20 23:18 ` Gerlach, Matthew
2025-03-20 16:46 ` [PATCH 2/4] EDAC, altera: update driver to reflect hw/yaml Matthew Gerlach
2025-03-21 21:12 ` Borislav Petkov
2025-03-23 16:13 ` Gerlach, Matthew
2025-03-20 16:46 ` [PATCH 3/4] arm64: dts: agilex: Update eccmgr in DTSI " Matthew Gerlach
2025-03-20 19:34 ` Rob Herring
2025-03-20 23:24 ` Gerlach, Matthew
2025-03-21 7:46 ` Krzysztof Kozlowski [this message]
2025-03-20 16:46 ` [PATCH 4/4] arm64: dts: startix10: Update eccmgr in DTSI/DTS " Matthew Gerlach
2025-03-20 18:26 ` [PATCH 0/4] dt-bindings: edac: altera-s10: Convert to YAML Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d37eb60d-fd84-4274-85ac-6ddfd32de3a5@kernel.org \
--to=krzk@kernel.org \
--cc=bp@alien8.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=james.morse@arm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@altera.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).