devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<lee@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <linus.walleij@linaro.org>,
	<broonie@kernel.org>, <tglx@linutronix.de>, <maz@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH 11/12] dt-bindings: sound: Add Cirrus Logic CS48L31/32/33 codecs
Date: Mon, 14 Nov 2022 12:34:09 +0000	[thread overview]
Message-ID: <d3868694-64b5-25e4-d955-2b86d643eb0c@opensource.cirrus.com> (raw)
In-Reply-To: <c7d73b1e-053f-21a7-4f4d-632742b4761c@linaro.org>

On 14/11/2022 11:03, Krzysztof Kozlowski wrote:
> On 14/11/2022 12:00, Richard Fitzgerald wrote:
>> On 14/11/2022 08:45, Krzysztof Kozlowski wrote:
>>> On 09/11/2022 17:53, Richard Fitzgerald wrote:
>>>> Codecs in this family have multiple digital and analog audio I/O that
>>>> support a variety of external hardware connections and configurations.
>>>>
>>>> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
>>>> ---
>>>>    .../bindings/sound/cirrus,cs48l32.yaml        | 96 +++++++++++++++++++
>>>>    include/dt-bindings/sound/cs48l32.h           | 25 +++++
>>>>    2 files changed, 121 insertions(+)
>>>>    create mode 100644 Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml
>>>>    create mode 100644 include/dt-bindings/sound/cs48l32.h
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml
>>>> new file mode 100644
>>>> index 000000000000..70fb294c6dc1
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs48l32.yaml
>>>> @@ -0,0 +1,96 @@
>>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/sound/cirrus,cs48l32.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Cirrus Logic CS48L31/32/33 audio CODECs
>>>> +
>>>> +maintainers:
>>>> +  - patches@opensource.cirrus.com
>>>> +
>>>> +description: |
>>>> +  This describes audio configuration bindings for these codecs.
>>>
>>> Don't start with "This". Instead describe the hardware.
>>>
>>>> +
>>>> +  See also the core bindings for the parent MFD driver:
>>>> +
>>>> +    Documentation/devicetree/bindings/mfd/cirrus,cs48l32.yaml
>>>
>>> Same comment as for pinctrl patch.
>>>
>>>> +
>>>> +  and defines for values used in these bindings:
>>>> +
>>>> +    include/dt-bindings/sound/cs48l32.h
>>>> +
>>>> +  The properties are all contained in the parent MFD node.
>>>> +
>>>> +properties:
>>>
>>> Missing compatible. What's the point to organize bindings like that? The
>>> schema on its own does nothing - does not match anything.
>>
>> Do you mean child drivers should not share the MFD node? Or do you mean
>> that if they share the MFD node all the child driver bindings should be
>> documented in the MFD schema instead of having a sub-schema for each
>> class of hardware functionality?
> 
> I mean, that regular binding has a compatible which allows the schema to
> be matched.
> 
> Splitting parts from top-level properties is used only for re-usable
> shared/common schemas, which does not seem the case here.
> 

Ok, that's good. None of these drivers are re-useable standalone.
I'll squash the bindings all into MFD schema for V2.

>>
>> I'm certainly willing to collapse all the bindings into a single MFD
>> schema yaml. For this driver we followed the same structure that was
>> accepted for madera (and there was some discussion when we upstreamed
>> madera about how the bindings should be organized which resulted in
>> them being changed). We pretty much assumed that the safe bet was to do
>> the same that was accepted by the maintainer last time around.
> 
> Just merge it with MFD binding.
> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2022-11-14 12:34 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 16:53 [PATCH 00/12] Add support for the Cirrus Logic CS48L32 audio codecs Richard Fitzgerald
2022-11-09 16:53 ` [PATCH 01/12] dt-bindings: mfd: Add Cirrus Logic CS48L32 audio codec Richard Fitzgerald
2022-11-09 21:09   ` Rob Herring
2022-11-14  8:36   ` Krzysztof Kozlowski
2022-11-09 16:53 ` [PATCH 02/12] mfd: cs48l32: Add register definitions for Cirrus Logic CS48L31/32/33 Richard Fitzgerald
2022-11-09 16:53 ` [PATCH 03/12] mfd: cs48l32: Add support for CS48L31/32/33 codecs Richard Fitzgerald
2022-11-11 23:07   ` kernel test robot
2022-11-16 15:43   ` Lee Jones
2022-11-09 16:53 ` [PATCH 04/12] dt-bindings: pinctrl: Add Cirrus Logic CS48L31/32/33 Richard Fitzgerald
2022-11-09 21:09   ` Rob Herring
2022-11-14  8:39   ` Krzysztof Kozlowski
2022-11-09 16:53 ` [PATCH 05/12] pinctrl: cirrus: Add support for CS48L31/32/33 codecs Richard Fitzgerald
2022-11-10 10:02   ` Linus Walleij
2022-11-10 10:55     ` Richard Fitzgerald
2022-11-12 21:01   ` kernel test robot
2022-11-09 16:53 ` [PATCH 06/12] regulator: arizona-micsupp: Don't hardcode use of ARIZONA defines Richard Fitzgerald
2022-11-09 16:53 ` [PATCH 07/12] regulator: arizona-micsupp: Don't use a common regulator name Richard Fitzgerald
2022-11-09 16:53 ` [PATCH 08/12] regulator: arizona-micsupp: Support Cirrus Logic CS48L31/32/33 Richard Fitzgerald
2022-11-09 16:53 ` [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs Richard Fitzgerald
2022-11-10  8:02   ` Marc Zyngier
2022-11-10 11:22     ` Richard Fitzgerald
2022-11-10 12:01       ` Marc Zyngier
2022-11-10 13:00         ` Richard Fitzgerald
2022-11-10 15:13           ` Marc Zyngier
2022-11-10 16:31             ` Richard Fitzgerald
2022-11-10 16:55               ` Mark Brown
2022-11-10 18:47               ` Marc Zyngier
2022-11-10 20:36                 ` Mark Brown
2022-11-11  8:00                   ` Marc Zyngier
2022-11-11 11:16                     ` Charles Keepax
2022-11-11 11:49                       ` Mark Brown
2022-11-11 13:01                         ` Charles Keepax
2022-11-11 13:00                       ` Charles Keepax
2022-11-16 16:44                     ` Mark Brown
2022-11-10 13:14         ` Richard Fitzgerald
2022-11-10 15:40           ` Marc Zyngier
2022-11-10 13:01       ` Mark Brown
2022-11-09 16:53 ` [PATCH 10/12] ASoC: wm_adsp: Allow client to hook into pre_run callback Richard Fitzgerald
2022-11-09 16:53 ` [PATCH 11/12] dt-bindings: sound: Add Cirrus Logic CS48L31/32/33 codecs Richard Fitzgerald
2022-11-09 21:09   ` Rob Herring
2022-11-14  8:45   ` Krzysztof Kozlowski
2022-11-14 11:00     ` Richard Fitzgerald
2022-11-14 11:03       ` Krzysztof Kozlowski
2022-11-14 12:34         ` Richard Fitzgerald [this message]
2022-11-09 16:53 ` [PATCH 12/12] ASoC: cs48l32: Add codec driver for Cirrus Logic CS48L31/32/33 Richard Fitzgerald
2022-11-10 20:20   ` kernel test robot
2022-11-10 20:53 ` [PATCH 00/12] Add support for the Cirrus Logic CS48L32 audio codecs Mark Brown
2022-11-11 13:50   ` Richard Fitzgerald
2022-11-23 13:11 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3868694-64b5-25e4-d955-2b86d643eb0c@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).