From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Roger Shimizu <rosh@debian.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT
Date: Fri, 6 Feb 2026 10:41:26 +0100 [thread overview]
Message-ID: <d398cd57-41b8-4646-834e-ff0c0b7ff749@kernel.org> (raw)
In-Reply-To: <eb9c1489-4496-48b3-8709-739cd45c11b0@oss.qualcomm.com>
On 04/02/2026 10:20, Konrad Dybcio wrote:
> On 1/31/26 11:31 AM, Roger Shimizu wrote:
>> ---
>
> [...]
>
>> +/ {
>> + model = "Thundercomm AI Mini PC G1 IoT";
>> + compatible = "qcom,sc7280", "qcom,qcm6490";
>
> You need to add a board-specific compatible here, see:
>
> Documentation/devicetree/bindings/arm/qcom.yaml
The true problem is that this would probably fail validation, so I
suspect this was never tested/checked.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-06 9:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 10:31 [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT Roger Shimizu
2026-02-04 2:51 ` Dmitry Baryshkov
2026-02-04 8:53 ` Roger Shimizu
2026-02-04 9:20 ` Konrad Dybcio
2026-02-05 0:04 ` Roger Shimizu
2026-02-05 8:52 ` Konrad Dybcio
2026-02-06 9:35 ` Roger Shimizu
2026-02-06 9:41 ` Krzysztof Kozlowski [this message]
2026-02-06 9:55 ` Roger Shimizu
2026-02-06 9:57 ` Konrad Dybcio
2026-02-07 5:46 ` Roger Shimizu
2026-02-09 8:31 ` Konrad Dybcio
2026-02-11 7:27 ` Roger Shimizu
2026-02-12 9:04 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d398cd57-41b8-4646-834e-ff0c0b7ff749@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosh@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox