From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0222DC433EF for ; Tue, 5 Jul 2022 10:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232486AbiGEKQk (ORCPT ); Tue, 5 Jul 2022 06:16:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbiGEKQj (ORCPT ); Tue, 5 Jul 2022 06:16:39 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3D001400F for ; Tue, 5 Jul 2022 03:16:37 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id i18so19712207lfu.8 for ; Tue, 05 Jul 2022 03:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=b+6rgPwFe0tNl/NgxJ4pfhsoXmLTVZo2+aHYzP/37tA=; b=HrPe8TcKTH37Go/o2X9x8G18AE8aCa8pQANYkhincCYfHWu9j2+stwjpFIGVXvNgtk WgKkrI1+MRRRYcsRyX/uwMs91tpa9mbFKHoElk2NjLSgxti1yeCz8lp/2jEt2v3EOKeQ xHht6qCHzdzXxnv571QycFaxMGvAN+8xbdCWMJWy1M+mMAr0/6xEye45xTcfJIUJFQz+ 3lVib2MQMsyZJRNlT2tL94vGr7tLagzLuxHlW/qj8UuOMm4pqI+9rn1uckwMj7jP/7as 1M1vLxfpbmMir+8hMFoyMKNK0V/E0PLltBOcCp+KwAM6GUvVh/oBPqtrvzezsbaSdOa9 LZ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=b+6rgPwFe0tNl/NgxJ4pfhsoXmLTVZo2+aHYzP/37tA=; b=dA1s4nE43qtOwXS3OxCH/I6SlOfbLaZ3pc46CdyCX2H7g6YdGEFamqpzL/GJhUFcy3 d/Ysogy6ukPxK1R4p2d435ME+mff8nA/oJXNU8LAlyejnK5SEVPZmvwHWxkE0NO2y+FU FDJf47Y2aIhWVYld44yU+Z17DuvAMtMZf/Axx/QiEGhbiibStwg4m0WRchx3JL+J/PUt faJOKG9S8NhRuxzRXe/tWGf3wOWI5Zc2oNMLtZ0EN7OJraugxY7rhmfPT88w+hkE5EtT XxbLPy/H+SZEroBI57lDMda9uSKregsGhxFTtSNocIhRgOKst0tRuXc2LP9KFspl8cZm Vc1Q== X-Gm-Message-State: AJIora9B9p7WyJWKN6/+v6kqmCQhF2XKZtfYl9J0e+8DQzljF2VpeStk MibUrjUkmqjvXnkNs/9LS6qLPA== X-Google-Smtp-Source: AGRyM1u2b+yi68OrYN6oZPBOKqn1kUsf6PZrDo4vaj7TdvAbPYg3ZsB5o6Xploz+F/eIOLJA/b8vTw== X-Received: by 2002:a19:ac09:0:b0:480:6a10:4c39 with SMTP id g9-20020a19ac09000000b004806a104c39mr23692141lfc.115.1657016196146; Tue, 05 Jul 2022 03:16:36 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id p6-20020a2ea4c6000000b0025be5d48ae7sm3617093ljm.79.2022.07.05.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 03:16:35 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 12:16:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused vddp-ref-clk supply Content-Language: en-US To: Johan Hovold , Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220705094239.17174-1-johan+linaro@kernel.org> <20220705094239.17174-17-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220705094239.17174-17-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 11:42, Johan Hovold wrote: > Only UFS PHY nodes in mainline have a vddp-ref-clk supply. Drop it from > the PCIe PHY binding. > That's not really good reason. Either the hardware uses ref-clk supply or not. Now it looks like you copied everything from common schema and clean things up. That's not how it should be organize. It's okay to copy existing bindings which are applicable and then in separate patch deprecate things or remove pieces which are not correct. But all this in assumption that the first copy already selected only applicable parts. Best regards, Krzysztof