From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tim Lunn <tim@feathertop.org>, Rob Herring <robh@kernel.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>, Zhang Qing <zhangqing@rock-chips.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rockchip: Add rk809 support for rk817 audio codec
Date: Wed, 17 Jan 2024 11:57:47 +0100 [thread overview]
Message-ID: <d3a764d1-c8bb-4ad6-be0d-40d37efaad69@linaro.org> (raw)
In-Reply-To: <6d828e2d-a25b-4784-9905-4a264b7d78fe@feathertop.org>
On 17/01/2024 11:38, Tim Lunn wrote:
>
> On 1/17/24 21:12, Krzysztof Kozlowski wrote:
>> On 17/01/2024 10:37, Tim Lunn wrote:
>>>> You can drop the description.
>>> Yes just 1 clock, i will fix this.
>>>>> +
>>>>> + clock-names:
>>>>> + description:
>>>>> + The clock name for the codec clock.
>>>> Drop.
>>> Just drop the description? I dont think can drop the clock names as the
>>> driver use the name to lookup clock:
>> Description. But anyway the problem is that adding clocks should be
>> separate patch with its own explanation.
>>
> Right, but I am not actually adding any clocks, just documenting what is
> already there.
You are. Binding did not have any clocks, now it has.
> There are already boards using this codec with rk809 in dts files and is
> working fine from driver side.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-17 10:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 8:46 [PATCH 0/3] dt-bindings: rockchip: Add support for rk809 audio codec Tim Lunn
2024-01-16 8:46 ` [PATCH 1/3] dt-bindings: rockchip: Add rk809 support for rk817 " Tim Lunn
2024-01-16 19:37 ` Rob Herring
2024-01-17 9:37 ` Tim Lunn
2024-01-17 10:12 ` Krzysztof Kozlowski
2024-01-17 10:38 ` Tim Lunn
2024-01-17 10:57 ` Krzysztof Kozlowski [this message]
2024-01-17 11:08 ` Tim Lunn
2024-01-16 8:46 ` [PATCH 2/3] dt-bindings: rockchip: rk809 fix compatible string in examples Tim Lunn
2024-01-16 11:08 ` Rob Herring
2024-01-16 19:37 ` Rob Herring
2024-01-16 19:39 ` Rob Herring
2024-01-17 7:42 ` Krzysztof Kozlowski
2024-01-16 8:46 ` [PATCH 3/3] dt-bindings: rockchip: Update rk809 example with audio codec properties Tim Lunn
2024-01-16 11:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3a764d1-c8bb-4ad6-be0d-40d37efaad69@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=tim@feathertop.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).