From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14B2C433B4 for ; Tue, 13 Apr 2021 14:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96FD9613B3 for ; Tue, 13 Apr 2021 14:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345308AbhDMO6k (ORCPT ); Tue, 13 Apr 2021 10:58:40 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58464 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345311AbhDMO62 (ORCPT ); Tue, 13 Apr 2021 10:58:28 -0400 Received: from mail-ed1-f72.google.com ([209.85.208.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lWKUO-0005BB-Us for devicetree@vger.kernel.org; Tue, 13 Apr 2021 14:58:05 +0000 Received: by mail-ed1-f72.google.com with SMTP id a1-20020aa7d7410000b0290378239baa9fso1411915eds.14 for ; Tue, 13 Apr 2021 07:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yJ2s7SvtJMvGXXT2TcTaXG1f4Lh8es6VQIDWtx4JoOk=; b=pghEtQfCuBApTmRhbdO/dP951IxJ+SP74fWT+h3F1E5saH1+gX135L5enMb8Vyo6sQ sMASyKD6GJDyvpSa2gx7KxOGF0/PvfAw0kV9trtMj6FrdWs1uo/2coCspmrURq9DyorU ZOiRCceUt9xzYojJasxBA6f/+L9H/575JJHUp7DCeINwW4GpOh7gPZRz4FBnu/k2PUQY cvfSucZHGJQu4+Rlussm1fwPcZtMMvdFDSsUadlGSRbo18oPXBb0BGYGagBe2YPHvATF WXZHtZ/OSQFlBZn/DX4Qfs3jcjuHVly1LzRufA8cPNt39cMajf7BBjW/a9k8sEoDU/xy 5OfA== X-Gm-Message-State: AOAM533rjl74OXaweWZmV6dd+KJXmLGKdO9Oq2R7Wpp42oOAzNAdfAlw xpOP3GlOK4j2FvaF0bCO/mi+AI9uwUSVp3oTH4BHhb5fsfYwGlhwvN5oyXSEEr5i+eE9l3+1tYF RARGQJM2ask4wYycAocm00fwhxylc/sebME38DGA= X-Received: by 2002:a17:906:f1cb:: with SMTP id gx11mr13865160ejb.106.1618325884588; Tue, 13 Apr 2021 07:58:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBS4f8/FtSKZIitrByeXvJ1+6fxGya2GdvXhrTkGICEYkSUaRVVNDzAJfvhqZqrKTZYiywqw== X-Received: by 2002:a17:906:f1cb:: with SMTP id gx11mr13865137ejb.106.1618325884439; Tue, 13 Apr 2021 07:58:04 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id c16sm8258136ejx.81.2021.04.13.07.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 07:58:04 -0700 (PDT) Subject: Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common To: Yong Wu Cc: Matthias Brugger , Joerg Roedel , Rob Herring , Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, chao.hao@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, eizan@chromium.org, acourbot@chromium.org References: <20210410091128.31823-1-yong.wu@mediatek.com> <20210410091128.31823-5-yong.wu@mediatek.com> <1618293876.20053.19.camel@mhfsdcap03> From: Krzysztof Kozlowski Message-ID: Date: Tue, 13 Apr 2021 16:58:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1618293876.20053.19.camel@mhfsdcap03> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2021 08:04, Yong Wu wrote: > On Sat, 2021-04-10 at 14:40 +0200, Krzysztof Kozlowski wrote: >> On 10/04/2021 11:11, Yong Wu wrote: >>> Normally, If the smi-larb HW need work, we should enable the smi-common >>> HW power and clock firstly. >>> This patch adds device-link between the smi-larb dev and the smi-common >>> dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync >>> (smi-common-dev) will be called automatically. >>> >>> Also, Add DL_FLAG_STATELESS to avoid the smi-common clocks be gated when >>> probe. >>> >>> CC: Matthias Brugger >>> Suggested-by: Tomasz Figa >>> Signed-off-by: Yong Wu >>> --- >>> drivers/memory/mtk-smi.c | 19 ++++++++++--------- >>> 1 file changed, 10 insertions(+), 9 deletions(-) >> >> I understood this is a dependency for other patches, so: >> Acked-by: Krzysztof Kozlowski >> >> If I am wrong and I can take it via memory tree, let me know. > > Hi Krzysztof, > > Thanks very much for your quickly review. > > I think it is ok if it go through memory tree. In the original patch, we > pm_runtime_get(smi-common-dev) in the smi-larb's pm resume callback. > This patch only use device-link do this. thus, this patch have no > function change. it only adjusts the SMI internal code flow. Hm, okay, I took it then for v5.13. > > In addition, [14/16] expects your Acked-by. and that one should be > merged with the others. Thanks for reminder. Best regards, Krzysztof