From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8241DA3A for ; Mon, 26 Feb 2024 11:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708948328; cv=none; b=ODb64YvtK/5oyzizJjgeGhI3uGfOvm2LJ4qP2WBuoZlPWlMe6mC5J6EhfJzJ7DCI1+/8kqDO2nzzMHE2keywep+s+zewHpGLwkdcMeU2WQJ4UBY6RispYtSnZws96l6ZFlpqIw4+1JFJ/vB2hswaXz5APuIl7GK3qlh8oFmLoGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708948328; c=relaxed/simple; bh=sOzOESPSJJuKs5PAS3HZPU1TL/jbqDPulGHUi2T1kSU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XSLOIjdJEphErEZJeVMX2cyQEejUuiO24hr71B6HjdXhSXgqiG3oYIRjSyaFqP0wSGGYJ84TcqYmTxl3BXsjgRO186L/FQCArjifoTyK6386mUhDYfGhSy6o1DgNDHt8i+RhQcPzmVpa8MOB2YOmMMqdsQHwNH1mqUVGkT81Oqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=b+S8ushs; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="b+S8ushs" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-412a3371133so7270645e9.2 for ; Mon, 26 Feb 2024 03:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1708948324; x=1709553124; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mz1uRkxJ9UbCLdRqQYDHAKRawtBRwIdQ/FjWHaCkwJM=; b=b+S8ushsfvjC3dYmVdCRBizJgeMP2nlvA00iE4V7Ngk/iSoyp0xUKS1LAhId/R/+8K o3lgB0ikWp/TJZpTI2GoqplVdoj9LIu66X/epE4gRYpCgqFhVpHWIz0ggFH9KH9a0rGb cDWry9ljQS3pI6+oRIdyWzTKL2y9epGF6By9wo1LUG3Ixq6sUGlxvFEbYxD+nv8IHVcN n6yGuV9xsuOC5MFh9Ta6yH+2E/Xycr0KnJsc/OwH8DPRng2ZfHquU2vOpsVywwg9MyMi varINfdFm4Upvyf8iiGueSDR7pKE5wFybYqWkD6u/YMwc/FGDuAnqOg8kwfakVgV5vAo dERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708948324; x=1709553124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mz1uRkxJ9UbCLdRqQYDHAKRawtBRwIdQ/FjWHaCkwJM=; b=caRlVp9ikSQZmd+0dAWOOcDq7IJbn6hWwNQVY86nM+biPM0ruwGptWmLhzP04g2uaw FWyOl4CERK/qA4iTmgdHRgwLvmWrSrmMMF+sytouqKpUVrFYHzDna1Qqw387JncENPZu MGTYZFfEVXKtUNncAkmFgUKonH79j5TWrrkXWiHoiNg4asJ9lvMfp9fpYMadgLWW1Wys D8jTZu3XmxmbbpYrkBYXVzXfPVlLaBgiPUVs69Q7F4ox14P0c9QBkaaZPZWMBlFUMNX3 I6dXcbP4gG4nKeZ6fC2V57fSZCQFRR979Ht/NFMSIRiRgGGkbGHr9wQyrzBlJRG7/9T3 ytNw== X-Forwarded-Encrypted: i=1; AJvYcCUp7SL1Tzpnk07CfmMotIiErPb3qMZH6wYA/ubdIEcbK7oX66IEj7Jb/pIzumRbU+YNbrV0Jt5HeSrj2SA8xajH2MwhNkft3wtbAg== X-Gm-Message-State: AOJu0YxHxNKvtMsRezu1RS/22BNKcrxQ/LIduYU28MyTRdL4S03VhN0n obV4u5aSMlldYfdPjR3psjLt5n1gZEp/r25EK2q50TuApTFZ2/gKMjIfSdrbaf8= X-Google-Smtp-Source: AGHT+IHuxCyz0aJYPuqa7jbzFzpVsMcqlrnBD87lnBA/2voj6xC84towYtJdrLWlnO4Avghcg9bmYQ== X-Received: by 2002:a05:600c:4e86:b0:412:a21b:d5d with SMTP id f6-20020a05600c4e8600b00412a21b0d5dmr2728429wmq.29.1708948324496; Mon, 26 Feb 2024 03:52:04 -0800 (PST) Received: from [192.168.1.70] ([84.102.31.43]) by smtp.gmail.com with ESMTPSA id 11-20020a05600c234b00b00412704a0e4asm11692160wmq.2.2024.02.26.03.52.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 03:52:04 -0800 (PST) Message-ID: Date: Mon, 26 Feb 2024 12:52:02 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/14] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Content-Language: en-US To: Bhargav Raviprakash , linux-kernel@vger.kernel.org Cc: m.nirmaladevi@ltts.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com, kristo@kernel.org References: <20240223093701.66034-1-bhargav.r@ltts.com> <20240223093701.66034-7-bhargav.r@ltts.com> From: Julien Panis In-Reply-To: <20240223093701.66034-7-bhargav.r@ltts.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/24 10:36, Bhargav Raviprakash wrote: > Add support for TPS65224 PMIC in the TPS6594 driver as they share > significant functional overlap. > > Signed-off-by: Bhargav Raviprakash > --- > drivers/mfd/tps6594-spi.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) This might be a nitpick, but for the next version of the series, please make commit message description for i2c VS spi drivers more homogeneous. Same comment for MODULE_DESCRIPTION (you changed it for i2c: why not, but then apply the same change to spi). With these changes, Acked-by: Julien Panis