From: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <tomi.valkeinen@ideasonboard.com>, <mchehab@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <hverkuil@xs4all.nl>,
<sakari.ailus@linux.intel.com>,
<laurent.pinchart@ideasonboard.com>, <hansg@kernel.org>,
<mehdi.djait@linux.intel.com>, <ribalda@chromium.org>,
<git@apitzsch.eu>, <vladimir.zapolskiy@linaro.org>,
<benjamin.mugnier@foss.st.com>, <dongcheng.yan@intel.com>,
<u-kumar1@ti.com>, <jai.luthra@linux.dev>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/4] media: dt-bindings: ti,ds90ub960: Refactor port definitions
Date: Wed, 10 Dec 2025 14:55:05 +0530 [thread overview]
Message-ID: <d3c8df6a-f9d7-4ce3-9da5-25af98be91c3@ti.com> (raw)
In-Reply-To: <20251205151158.GA158904-robh@kernel.org>
Hi Rob,
Thanks for the review.
On 05/12/25 20:41, Rob Herring wrote:
> On Tue, Dec 02, 2025 at 03:52:05PM +0530, Yemike Abhilash Chandra wrote:
>> The current bindings duplicate the port definitions for each FPD-Link RX
>> and CSI-2 TX ports. This results in a large amount of repeated schema
>> blocks and makes it harder to extend the bindings for new devices.
>>
>> Refactor the bindings by introducing shared deftinitions for FPD-Link
>> input ports and CSI-2 output ports. No functional change intended.
>>
>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>> ---
>> .../bindings/media/i2c/ti,ds90ub960.yaml | 120 +++++++-----------
>> 1 file changed, 44 insertions(+), 76 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
>> index 0539d52de422..6a78288aebaa 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
>> @@ -125,102 +125,35 @@ properties:
>>
>> ports:
>> $ref: /schemas/graph.yaml#/properties/ports
>> + description: |
>
> Don't need '|' unless you have formatting to preserve.
>
Understood. I will fix this in v3.
>> + Ports represent FPD-Link inputs to the deserializer and CSI TX outputs from the deserializer.
>> + Their number is model-dependent.
>
> 'The number of ports is...'
>
> Wrap lines at 80.
>
I will fix this in v3.
Thanks and Regards,
Yemike Abhilash Chandra
>>
>> properties:
>> port@0:
>> - $ref: /schemas/graph.yaml#/$defs/port-base
>> - unevaluatedProperties: false
>> + $ref: '#/$defs/FPDLink-input-port'
>> description: FPD-Link input 0
>>
>> - properties:
>> - endpoint:
>> - $ref: /schemas/media/video-interfaces.yaml#
>> - unevaluatedProperties: false
>> - description:
>> - Endpoint for FPD-Link port. If the RX mode for this port is RAW,
>> - hsync-active and vsync-active must be defined.
>> -
>> port@1:
>> - $ref: /schemas/graph.yaml#/$defs/port-base
>> - unevaluatedProperties: false
>> + $ref: '#/$defs/FPDLink-input-port'
>> description: FPD-Link input 1
>>
>> - properties:
>> - endpoint:
>> - $ref: /schemas/media/video-interfaces.yaml#
>> - unevaluatedProperties: false
>> - description:
>> - Endpoint for FPD-Link port. If the RX mode for this port is RAW,
>> - hsync-active and vsync-active must be defined.
>> -
>> port@2:
>> - $ref: /schemas/graph.yaml#/$defs/port-base
>> - unevaluatedProperties: false
>> + $ref: '#/$defs/FPDLink-input-port'
>> description: FPD-Link input 2
>>
>> - properties:
>> - endpoint:
>> - $ref: /schemas/media/video-interfaces.yaml#
>> - unevaluatedProperties: false
>> - description:
>> - Endpoint for FPD-Link port. If the RX mode for this port is RAW,
>> - hsync-active and vsync-active must be defined.
>> -
>> port@3:
>> - $ref: /schemas/graph.yaml#/$defs/port-base
>> - unevaluatedProperties: false
>> + $ref: '#/$defs/FPDLink-input-port'
>> description: FPD-Link input 3
>>
>> - properties:
>> - endpoint:
>> - $ref: /schemas/media/video-interfaces.yaml#
>> - unevaluatedProperties: false
>> - description:
>> - Endpoint for FPD-Link port. If the RX mode for this port is RAW,
>> - hsync-active and vsync-active must be defined.
>> -
>> port@4:
>> - $ref: /schemas/graph.yaml#/$defs/port-base
>> - unevaluatedProperties: false
>> + $ref: '#/$defs/CSI2-output-port'
>> description: CSI-2 Output 0
>>
>> - properties:
>> - endpoint:
>> - $ref: /schemas/media/video-interfaces.yaml#
>> - unevaluatedProperties: false
>> -
>> - properties:
>> - data-lanes:
>> - minItems: 1
>> - maxItems: 4
>> - link-frequencies:
>> - maxItems: 1
>> -
>> - required:
>> - - data-lanes
>> - - link-frequencies
>> -
>> port@5:
>> - $ref: /schemas/graph.yaml#/$defs/port-base
>> - unevaluatedProperties: false
>> + $ref: '#/$defs/CSI2-output-port'
>> description: CSI-2 Output 1
>>
>> - properties:
>> - endpoint:
>> - $ref: /schemas/media/video-interfaces.yaml#
>> - unevaluatedProperties: false
>> -
>> - properties:
>> - data-lanes:
>> - minItems: 1
>> - maxItems: 4
>> - link-frequencies:
>> - maxItems: 1
>> -
>> - required:
>> - - data-lanes
>> - - link-frequencies
>> -
>> required:
>> - port@0
>> - port@1
>> @@ -236,6 +169,41 @@ required:
>> - clock-names
>> - ports
>>
>> +$defs:
>> + FPDLink-input-port:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: FPD-Link input
>> +
>> + properties:
>> + endpoint:
>> + $ref: /schemas/media/video-interfaces.yaml#
>> + unevaluatedProperties: false
>> + description:
>> + Endpoint for FPD-Link port. If the RX mode for this port is RAW,
>> + hsync-active and vsync-active must be defined.
>> +
>> + CSI2-output-port:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: CSI-2 Output
>> +
>> + properties:
>> + endpoint:
>> + $ref: /schemas/media/video-interfaces.yaml#
>> + unevaluatedProperties: false
>> +
>> + properties:
>> + data-lanes:
>> + minItems: 1
>> + maxItems: 4
>> + link-frequencies:
>> + maxItems: 1
>> +
>> + required:
>> + - data-lanes
>> + - link-frequencies
>> +
>> unevaluatedProperties: false
>>
>> examples:
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2025-12-10 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 10:22 [PATCH V2 0/4] Add support for DS90UB954-Q1 Yemike Abhilash Chandra
2025-12-02 10:22 ` [PATCH V2 1/4] media: dt-bindings: ti,ds90ub960: Refactor port definitions Yemike Abhilash Chandra
2025-12-05 15:11 ` Rob Herring
2025-12-10 9:25 ` Yemike Abhilash Chandra [this message]
2025-12-02 10:22 ` [PATCH V2 2/4] media: i2c: ds90ub960: Use enums for chip type and chip family Yemike Abhilash Chandra
2025-12-05 10:46 ` Tomi Valkeinen
2025-12-02 10:22 ` [PATCH V2 3/4] media: dt-bindings: ti,ds90ub960: Add support for DS90UB954-Q1 Yemike Abhilash Chandra
2025-12-05 15:17 ` Rob Herring
2025-12-10 9:33 ` Yemike Abhilash Chandra
2025-12-02 10:22 ` [PATCH V2 4/4] media: i2c: ds90ub960: " Yemike Abhilash Chandra
2025-12-05 11:10 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c8df6a-f9d7-4ce3-9da5-25af98be91c3@ti.com \
--to=y-abhilashchandra@ti.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongcheng.yan@intel.com \
--cc=git@apitzsch.eu \
--cc=hansg@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jai.luthra@linux.dev \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=ribalda@chromium.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=u-kumar1@ti.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).