From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Joey Gouly <joey.gouly@arm.com>
Cc: linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
marcan@marcan.st, maz@kernel.org,
alyssa.rosenzweig@collabora.com, sven@svenpeter.dev,
devicetree@vger.kernel.org, robh+dt@kernel.org,
kettenis@openbsd.org, nd@arm.com, joey.gouly@arm.com
Subject: Re: [PATCH v2 2/3] dt-bindings: pinctrl: Add apple,npins property to apple,pinctrl
Date: Fri, 1 Oct 2021 22:01:23 +0200 (CEST) [thread overview]
Message-ID: <d3ca2fefcce5e048@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211001191209.29988-3-joey.gouly@arm.com> (message from Joey Gouly on Fri, 1 Oct 2021 20:12:08 +0100)
> From: Joey Gouly <joey.gouly@arm.com>
> Date: Fri, 1 Oct 2021 20:12:08 +0100
>
> This property is used to describe the total number of pins on this
> particular pinctrl hardware block.
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
> Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
Adding does property doesn't break the U-Boot driver, so I'm ok with
this. This should probably be a required property though.
> diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
> index d50571affd1f..cdd8cb454e92 100644
> --- a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
> @@ -34,6 +34,9 @@ properties:
> gpio-ranges:
> maxItems: 1
>
> + apple,npins:
> + maxItems: 1
> +
> interrupts:
> description: One interrupt for each of the (up to 7) interrupt
> groups supported by the controller sorted by interrupt group
> @@ -86,6 +89,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> gpio-ranges = <&pinctrl 0 0 212>;
> + apple,npins = <212>;
>
> interrupt-controller;
> interrupt-parent = <&aic>;
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2021-10-01 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 19:12 [PATCH v2 0/3] pinctrl/GPIO driver for Apple SoCs Joey Gouly
2021-10-01 19:12 ` [PATCH v2 1/3] gpio: Allow per-parent interrupt data Joey Gouly
2021-10-03 22:21 ` Linus Walleij
2021-10-01 19:12 ` [PATCH v2 2/3] dt-bindings: pinctrl: Add apple,npins property to apple,pinctrl Joey Gouly
2021-10-01 20:01 ` Mark Kettenis [this message]
2021-10-01 23:02 ` Rob Herring
2021-10-03 22:23 ` Linus Walleij
2021-10-01 19:12 ` [PATCH v2 3/3] pinctrl: add pinctrl/GPIO driver for Apple SoCs Joey Gouly
2021-10-03 22:35 ` Linus Walleij
2021-10-04 3:33 ` Hector Martin
2021-10-14 20:24 ` Joey Gouly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ca2fefcce5e048@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa.rosenzweig@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=joey.gouly@arm.com \
--cc=kettenis@openbsd.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=nd@arm.com \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).