From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Hector Martin <marcan@marcan.st>
Cc: linux-arm-kernel@lists.infradead.org, marcan@marcan.st,
maz@kernel.org, robh+dt@kernel.org, arnd@kernel.org,
linus.walleij@linaro.org, alyssa@rosenzweig.io, krzk@kernel.org,
gregkh@linuxfoundation.org, p.zabel@pengutronix.de,
rafael@kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 4/7] arm64: dts: apple: t8103: Rename clk24 to clkref
Date: Tue, 5 Oct 2021 22:22:32 +0200 (CEST) [thread overview]
Message-ID: <d3ca3c03afb34abe@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211005155923.173399-5-marcan@marcan.st> (message from Hector Martin on Wed, 6 Oct 2021 00:59:20 +0900)
> From: Hector Martin <marcan@marcan.st>
> Date: Wed, 6 Oct 2021 00:59:20 +0900
> Content-Type: text/plain; charset="us-ascii"
>
> We now know that this frequency comes from the external reference
> oscillator and is used for various SoC blocks, and isn't just a random
> 24MHz clock, so let's call it something more appropriate.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> arch/arm64/boot/dts/apple/t8103.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index a1e22a2ea2e5..9f60f9e48ea0 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -95,11 +95,11 @@ timer {
> <AIC_FIQ AIC_TMR_HV_VIRT IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - clk24: clock-24m {
> + clkref: clock-ref {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <24000000>;
> - clock-output-names = "clk24";
> + clock-output-names = "clkref";
> };
>
> soc {
> @@ -120,7 +120,7 @@ serial0: serial@235200000 {
> * TODO: figure out the clocking properly, there may
> * be a third selectable clock.
> */
> - clocks = <&clk24>, <&clk24>;
> + clocks = <&clkref>, <&clkref>;
> clock-names = "uart", "clk_uart_baud0";
> status = "disabled";
> };
> --
> 2.33.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2021-10-05 20:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 15:59 [PATCH 0/7] Apple SoC PMGR device power states driver Hector Martin
2021-10-05 15:59 ` [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding Hector Martin
2021-10-05 20:09 ` Mark Kettenis
2021-10-05 22:45 ` Rob Herring
2021-10-06 15:17 ` Hector Martin
2021-10-06 6:56 ` Krzysztof Kozlowski
2021-10-06 7:30 ` Krzysztof Kozlowski
2021-10-06 15:21 ` Hector Martin
2021-10-06 15:26 ` Hector Martin
2021-10-07 13:10 ` Krzysztof Kozlowski
2021-10-05 15:59 ` [PATCH 2/7] dt-bindings: power: Add apple,pmgr-pwrstate binding Hector Martin
2021-10-05 20:16 ` Mark Kettenis
2021-10-06 15:27 ` Hector Martin
2021-10-06 0:58 ` Rob Herring
2021-10-06 15:52 ` Hector Martin
2021-10-06 15:55 ` Hector Martin
2021-10-08 7:50 ` Krzysztof Kozlowski
2021-10-11 5:17 ` Hector Martin
2021-10-06 7:05 ` Krzysztof Kozlowski
2021-10-06 15:59 ` Hector Martin
2021-10-07 13:12 ` Krzysztof Kozlowski
2021-10-11 4:42 ` Hector Martin
2021-10-05 15:59 ` [PATCH 3/7] soc: apple: Add driver for Apple PMGR power state controls Hector Martin
2021-10-05 16:08 ` Linus Walleij
2021-10-05 16:15 ` Hector Martin
2021-10-05 19:49 ` Linus Walleij
2021-10-05 20:21 ` Mark Kettenis
2021-10-06 16:00 ` Hector Martin
2021-10-06 7:28 ` Krzysztof Kozlowski
2021-10-06 16:08 ` Hector Martin
2021-10-06 9:24 ` Philipp Zabel
2021-10-06 16:11 ` Hector Martin
2021-10-05 15:59 ` [PATCH 4/7] arm64: dts: apple: t8103: Rename clk24 to clkref Hector Martin
2021-10-05 20:22 ` Mark Kettenis [this message]
2021-10-05 15:59 ` [PATCH 5/7] arm64: dts: apple: t8103: Add the UART PMGR tree Hector Martin
2021-10-05 20:25 ` Mark Kettenis
2021-10-05 15:59 ` [PATCH 6/7] tty: serial: samsung_tty: Support runtime PM Hector Martin
2021-10-06 7:43 ` Krzysztof Kozlowski
2021-10-06 13:25 ` Rafael J. Wysocki
2021-10-06 13:29 ` Krzysztof Kozlowski
2021-10-11 5:32 ` Hector Martin
2021-10-11 6:48 ` Krzysztof Kozlowski
2021-10-11 8:27 ` Johan Hovold
2021-10-05 15:59 ` [PATCH 7/7] arm64: dts: apple: t8103: Add UART2 Hector Martin
2021-10-05 20:26 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ca3c03afb34abe@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa@rosenzweig.io \
--cc=arnd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).