devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Janne Grunau <j@jannau.net>
Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io,
	robh+dt@kernel.org, maz@kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet
Date: Mon, 15 Nov 2021 12:44:07 +0100 (CET)	[thread overview]
Message-ID: <d3cad763b256e68e@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211115094332.13540-1-j@jannau.net> (message from Janne Grunau on Mon, 15 Nov 2021 10:43:32 +0100)

> From: Janne Grunau <j@jannau.net>
> Date: Mon, 15 Nov 2021 10:43:32 +0100
> 
> Fixes make dtbs_check errors for t8103-j274.dts due to missing pci
> properties.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>

Yes, that is better.

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---8<---
> 
> change based on the same pattern as in
> arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts
> 
> ---
>  arch/arm64/boot/dts/apple/t8103-j274.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
> index 33a80f9501dc..02c36301e985 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
> @@ -60,7 +60,7 @@ &port01 {
>  
>  &port02 {
>  	bus-range = <3 3>;
> -	ethernet0: pci@0,0 {
> +	ethernet0: ethernet@0,0 {
>  		reg = <0x30000 0x0 0x0 0x0 0x0>;
>  		/* To be filled by the loader */
>  		local-mac-address = [00 10 18 00 00 00];
> -- 
> 2.33.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

      reply	other threads:[~2021-11-15 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  9:43 [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet Janne Grunau
2021-11-15 11:44 ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3cad763b256e68e@bloch.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=alyssa@rosenzweig.io \
    --cc=devicetree@vger.kernel.org \
    --cc=j@jannau.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sven@svenpeter.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).