Re: [PATCH v2 3/3] arm64: dts: apple: add #interrupt-cells property to pinctrl nodes

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> From: Janne Grunau <j@jannau.net>
> Date: Mon, 22 Nov 2021 23:24:40 +0100
> 
> Required for devices trying to use pinctrl devices as interrupt
> controller.
> 
> Fixes: 0a8282b83119 ("arm64: apple: Add pinctrl nodes")
> Signed-off-by: Janne Grunau <j@jannau.net>
> Cc: Mark Kettenis <kettenis@openbsd.org>
> Reviewed-by: Sven Peter <sven@svenpeter.dev>

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---
>  arch/arm64/boot/dts/apple/t8103.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index fc8b2bb06ffe..c320c8baeb41 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -143,6 +143,7 @@ pinctrl_ap: pinctrl@23c100000 {
>  			apple,npins = <212>;
>  
>  			interrupt-controller;
> +			#interrupt-cells = <2>;
>  			interrupt-parent = <&aic>;
>  			interrupts = <AIC_IRQ 190 IRQ_TYPE_LEVEL_HIGH>,
>  				     <AIC_IRQ 191 IRQ_TYPE_LEVEL_HIGH>,
> @@ -169,6 +170,7 @@ pinctrl_aop: pinctrl@24a820000 {
>  			apple,npins = <42>;
>  
>  			interrupt-controller;
> +			#interrupt-cells = <2>;
>  			interrupt-parent = <&aic>;
>  			interrupts = <AIC_IRQ 268 IRQ_TYPE_LEVEL_HIGH>,
>  				     <AIC_IRQ 269 IRQ_TYPE_LEVEL_HIGH>,
> @@ -189,6 +191,7 @@ pinctrl_nub: pinctrl@23d1f0000 {
>  			apple,npins = <23>;
>  
>  			interrupt-controller;
> +			#interrupt-cells = <2>;
>  			interrupt-parent = <&aic>;
>  			interrupts = <AIC_IRQ 330 IRQ_TYPE_LEVEL_HIGH>,
>  				     <AIC_IRQ 331 IRQ_TYPE_LEVEL_HIGH>,
> @@ -209,6 +212,7 @@ pinctrl_smc: pinctrl@23e820000 {
>  			apple,npins = <16>;
>  
>  			interrupt-controller;
> +			#interrupt-cells = <2>;
>  			interrupt-parent = <&aic>;
>  			interrupts = <AIC_IRQ 391 IRQ_TYPE_LEVEL_HIGH>,
>  				     <AIC_IRQ 392 IRQ_TYPE_LEVEL_HIGH>,
> -- 
> 2.34.0
> 
>