From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Janne Grunau <j@jannau.net>
Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io,
robh+dt@kernel.org, wsa@kernel.org, olof@lixom.net,
arnd@arndb.de, kettenis@openbsd.org, robh@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: i2c: apple,i2c: allow multiple compatibles
Date: Mon, 22 Nov 2021 23:39:12 +0100 (CET) [thread overview]
Message-ID: <d3caf42a8fea181b@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211122222440.21177-3-j@jannau.net> (message from Janne Grunau on Mon, 22 Nov 2021 23:24:39 +0100)
> From: Janne Grunau <j@jannau.net>
> Date: Mon, 22 Nov 2021 23:24:39 +0100
>
> The intention was to have a SoC-specific and base compatible string
> to allow forward compatibility and SoC specific quirks,
>
> Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings")
> Signed-off-by: Janne Grunau <j@jannau.net>
> Cc: Mark Kettenis <kettenis@openbsd.org>
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> index 22fc8483256f..82b953181a52 100644
> --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> @@ -20,9 +20,9 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - apple,t8103-i2c
> - - apple,i2c
> + items:
> + - const: apple,t8103-i2c
> + - const: apple,i2c
>
> reg:
> maxItems: 1
> @@ -51,7 +51,7 @@ unevaluatedProperties: false
> examples:
> - |
> i2c@35010000 {
> - compatible = "apple,t8103-i2c";
> + compatible = "apple,t8103-i2c", "apple,i2c";
> reg = <0x35010000 0x4000>;
> interrupt-parent = <&aic>;
> interrupts = <0 627 4>;
> --
> 2.34.0
>
>
next prev parent reply other threads:[~2021-11-22 22:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 22:24 [PATCH v2 0/3] Apple Arm patform device tree and bindings fixes Janne Grunau
2021-11-22 22:24 ` [PATCH v2 1/3] arm64: dts: apple: change ethernet0 device type to ethernet Janne Grunau
2021-11-22 22:24 ` [PATCH v2 2/3] dt-bindings: i2c: apple,i2c: allow multiple compatibles Janne Grunau
2021-11-22 22:39 ` Mark Kettenis [this message]
2021-11-23 9:48 ` Wolfram Sang
2021-11-30 21:07 ` Rob Herring
2021-11-22 22:24 ` [PATCH v2 3/3] arm64: dts: apple: add #interrupt-cells property to pinctrl nodes Janne Grunau
2021-11-22 22:37 ` Mark Kettenis
2021-11-23 4:27 ` [PATCH v2 0/3] Apple Arm patform device tree and bindings fixes Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3caf42a8fea181b@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa@rosenzweig.io \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=kettenis@openbsd.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).