From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABEAC433EF for ; Mon, 18 Apr 2022 11:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbiDRLX7 (ORCPT ); Mon, 18 Apr 2022 07:23:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbiDRLX6 (ORCPT ); Mon, 18 Apr 2022 07:23:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21BA91A397; Mon, 18 Apr 2022 04:21:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E62C60ACF; Mon, 18 Apr 2022 11:21:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EC65C385A1; Mon, 18 Apr 2022 11:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650280879; bh=JtbuCbrZbi3dPFYVVkBHNhS7wJ87kP5Yh2cP76lFqDg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iRreG9ldmKxo4O/bDI2DATJ5fXcEBD5AcronFDUmy399cld5aXrndE3vasr4q+FTL XjAMdMr3q+Y2sd8xcERorbyBAWSNFLiLrHvaDLry2x3h2XeJm/bHyH4uwGSOwgqIqB /93jK4SXYdiTHQDn+Ijj2KOJv2pUtfbVIiKbk5z2fA+uTdbQ7ujExUaSPr/S+So1Pa Uv/amKFBMb7UMKynsLQx+enwEEu2YMKlfyyEsJV4bnmWNzRA8PDzMoEAKd1B6angot Wj1SUQS0villydBBCU/5YWd5fUQk5uFkpvZiRFUpJaL8WPaVfNr6KqO6LhPAdFem1Y 6tzkJByFsapGA== Message-ID: Date: Mon, 18 Apr 2022 13:21:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add Hardkernel ODROID-M1 board Content-Language: en-US To: Heiko Stuebner , Peter Geis Cc: Dongjin Kim , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List References: <20220329094446.415219-1-tobetter@gmail.com> <12089439.O9o76ZdvQC@phil> From: Krzysztof Kozlowski In-Reply-To: <12089439.O9o76ZdvQC@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/04/2022 22:55, Heiko Stuebner wrote: >> Usually adding - in subsequent DTS files - means increasing the numbers >> so if you have regulator-[012] then just use regulator-[345] in other >> files. I see potential mess when you combine several DTSI files, each >> defining regulators, so in such case "some-name-regulator" (or reversed) >> is also popular approach. > > so going with > > dc_12v: dc-12v-regulator { > }; > > i.e. doing a some-name-regulator would be an in-spec way to go? > > In this case I would definitely prefer this over doing a numbered thing. > > I.e. regulator-0 can create really hard to debug issues, when you have > another accidential regulator-0 for a different regulator in there, which > then would create some sort of merged node. I don't think such case happens frequently, because all regulators are usually used by something (as a phandle) thus they should have a label. This label should be descriptive, so if one can assign same label to entirely different regulators, then the same chances are that same descriptive node will be used. IOW, if you think such mistake with regulator names can happen, then the same can happen with the label... Anyway, answering the question - "dc-12v-regulator" is still not matching exactly the Devicetree spec recommendation, but it's okay for me. :) Best regards, Krzysztof