devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Hector Martin <marcan@marcan.st>
Cc: sven@svenpeter.dev, jassisinghbrar@gmail.com, robh+dt@kernel.org,
	marcan@marcan.st, alyssa@rosenzweig.io, kettenis@openbsd.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: apple, mailbox: Add generic and t6000 compatibles
Date: Thu, 9 Dec 2021 15:16:17 +0100 (CET)	[thread overview]
Message-ID: <d3cb3991a2be5ea4@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211209055049.99205-2-marcan@marcan.st> (message from Hector Martin on Thu, 9 Dec 2021 14:50:48 +0900)

> From: Hector Martin <marcan@marcan.st>
> Date: Thu,  9 Dec 2021 14:50:48 +0900
> 
> Much as we've done with other blocks, let's introduce generic
> compatibles so drivers can bind to those and still work with future
> SoCs, as long as the hardware remains the same. Also go ahead and add
> compatibles for the new t600x SoCs (we group those as t6000).
> 
> Note that no DTs instantiate devices with this binding yet.

I think this makes sense.  There is no OpenBSD driver for this yet and
my U-Boot driver has not been submitted upstream yet.  So I think
there are no real backwards compatibility issues.

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  .../devicetree/bindings/mailbox/apple,mailbox.yaml   | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml b/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
> index 2c1704b34e7a..58007c789671 100644
> --- a/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
> @@ -27,14 +27,20 @@ properties:
>            for example for the display controller, the system management
>            controller and the NVMe coprocessor.
>          items:
> -          - const: apple,t8103-asc-mailbox
> +          - enum:
> +              - apple,t8103-asc-mailbox
> +              - apple,t6000-asc-mailbox
> +          - const: apple,asc-mailbox
>  
>        - description:
>            M3 mailboxes are an older variant with a slightly different MMIO
>            interface still found on the M1. It is used for the Thunderbolt
>            co-processors.
>          items:
> -          - const: apple,t8103-m3-mailbox
> +          - enum:
> +              - apple,t8103-m3-mailbox
> +              - apple,t6000-m3-mailbox
> +          - const: apple,m3-mailbox
>  
>    reg:
>      maxItems: 1
> @@ -68,7 +74,7 @@ additionalProperties: false
>  examples:
>    - |
>          mailbox@77408000 {
> -                compatible = "apple,t8103-asc-mailbox";
> +                compatible = "apple,t8103-asc-mailbox", "apple,asc-mailbox";
>                  reg = <0x77408000 0x4000>;
>                  interrupts = <1 583 4>, <1 584 4>, <1 585 4>, <1 586 4>;
>                  interrupt-names = "send-empty", "send-not-empty",
> -- 
> 2.33.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

  reply	other threads:[~2021-12-09 14:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09  5:50 [PATCH 0/2] Apple mailbox fixup: switch to generic compatibles Hector Martin
2021-12-09  5:50 ` [PATCH 1/2] dt-bindings: mailbox: apple,mailbox: Add generic and t6000 compatibles Hector Martin
2021-12-09 14:16   ` Mark Kettenis [this message]
2021-12-15 16:59   ` Rob Herring
2021-12-15 17:13   ` Sven Peter
2021-12-15 17:14     ` Sven Peter
2021-12-09  5:50 ` [PATCH 2/2] mailbox: apple: Bind to generic compatibles Hector Martin
2021-12-09 16:33 ` [PATCH 0/2] Apple mailbox fixup: switch " Sven Peter
2021-12-13  3:55   ` Hector Martin
2021-12-15  8:43     ` Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3cb3991a2be5ea4@bloch.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=alyssa@rosenzweig.io \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=kettenis@openbsd.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=robh+dt@kernel.org \
    --cc=sven@svenpeter.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).