Re: [PATCH v3 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts

[Fabrice Gasnier <fabrice.gasnier@foss.st.com>]

On 4/8/22 08:35, Uwe Kleine-König wrote:
> The timer units in the stm32mp1 CPUs have interrupts, depending on the
> timer flavour either one "global" or four dedicated ones. Document how
> to formalize these in a device tree.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  .../devicetree/bindings/mfd/st,stm32-timers.yaml    | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> index 10b330d42901..5e4214d1613b 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> @@ -46,6 +46,19 @@ properties:
>      minItems: 1
>      maxItems: 7
>  
> +  interrupts:
> +    maxItems: 4

Hi Uwe,

Rob posted a remark in V1, which need to be taken IMHO:

https://lore.kernel.org/all/CAL_JsqKW3XJ6n5CLg_BNEaASkUnXLM=J_XZW8M6i7sGPuZ8_9A@mail.gmail.com/

Running a dtbs_check with dts change, shows some issues like:
...timer@40000000: interrupts: [[0, 28, 4]] is too short
...timer@40001000: interrupts: [[0, 29, 4]] is too short
...

It should be ok with Rob's proposal.

Thanks,
Best Regards,
Fabrice

> +
> +  interrupt-names:
> +    anyOf:
> +      - items:
> +          - const: global
> +      - items:
> +          - const: brk
> +          - const: up
> +          - const: trg-com
> +          - const: cc
> +
>    "#address-cells":
>      const: 1
>