From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B671ECAAA1 for ; Fri, 9 Sep 2022 08:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbiIIIpH (ORCPT ); Fri, 9 Sep 2022 04:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231592AbiIIIpF (ORCPT ); Fri, 9 Sep 2022 04:45:05 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF6D78A7DD for ; Fri, 9 Sep 2022 01:45:02 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id bq23so1522737lfb.7 for ; Fri, 09 Sep 2022 01:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ZSXnk2kkT4RDB6r1y9rOYCpY5Yh7WRqMxlBS7mQ+NX4=; b=EW6l4VUKTQmo5nbMnx5ALSP2h2pfm9mA1GTx67eLPWIl9p1wcHW2eokPugIL8OTYoB rsR2EYm8TAhnbAQ5BDzAZpxi++EAeXCI7h+r0nMP2BRi1qvx+geiISU1FiOmEJEEPHkK QSAYXgmZg2ifces3aga5Cwvh9CoRywBGNlaO8aZnezaKcHyiP8Wq3fA63brrYQI3xHSs 1BiMFNnBK3h6zB7gnYllqXTwelSURAK50oCkL91L6csUiqYTLKmMSJNMazlMQpzVSROQ O+biMxxdXb+PMMfxxWYVA047P+mSnHl3B0aHpLxze/+F4LCKrDTIlVbOWMVFfXhbzsyI XzZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ZSXnk2kkT4RDB6r1y9rOYCpY5Yh7WRqMxlBS7mQ+NX4=; b=gdgbf3rZzDZB7JTABPJP9XObabEEd1SL2gJiRqPetduuOm3RNB9tHcBzNDo9FtVuw8 9yCkCR2IY2detk2brijapJrj3/uBxGGlkrIrfP7LJy4hsZMBM1QMtTfSwZz+5OGkZPB3 T7TarSX9fsINWnfgldYzo37+IjeeZXKe5152HVwzk9gg31C1JtIZtCMqvQYrtNTDuMVu skjvSSJYAdkotxxe3h6Q8kjk+5YRvbj0L/zK9StewDO2Y5qjrbf/wBlKpwbcti974p2f xmCDflcySEDGSpgx9e6i1dC8oG7q5NwRUspkmXgZoDjRyizt8Z8WkvVRw7hC6dMdI3Oc mADA== X-Gm-Message-State: ACgBeo35CboTbDq2E/gFVlfOIEqxXgS1IGM/cdRfh4ol08ULWLENyEoD 25hswdabShBavAMGgq5f8FLgKQ== X-Google-Smtp-Source: AA6agR7IWO5ppTJQJUDrlLe10NtRpPdhs1Ls7YIUiy+dNvD1kTX6h52BulmUCDgX6Sb7b9J3bq1LAw== X-Received: by 2002:ac2:4e10:0:b0:498:f132:d5c1 with SMTP id e16-20020ac24e10000000b00498f132d5c1mr2146029lfr.648.1662713101149; Fri, 09 Sep 2022 01:45:01 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b15-20020a056512060f00b00497a191bf23sm175671lfe.299.2022.09.09.01.44.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 01:45:00 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 10:44:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v7 3/4] dt-bindings: hwmon: Add bindings for max31760 Content-Language: en-US To: Ibrahim Tilki , jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220909071618.231246-1-Ibrahim.Tilki@analog.com> <20220909071618.231246-4-Ibrahim.Tilki@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20220909071618.231246-4-Ibrahim.Tilki@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/09/2022 09:16, Ibrahim Tilki wrote: > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller > > Signed-off-by: Ibrahim Tilki > --- > .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > new file mode 100644 > index 000000000..003ec1317 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/adi,max31760.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX31760 Fan-Speed Controller > + > +maintainers: > + - Ibrahim Tilki > + > +description: | > + Analog Devices MAX31760 Fan-Speed Controller > + https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf > + > +properties: > + compatible: > + enum: > + - adi,max31760 > + > + reg: > + description: | No need for | > + I2C address of slave device. maxItems: 1 > + items: > + minimum: 0x50 > + maximum: 0x57 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { Just i2c. > + #address-cells = <1>; > + #size-cells = <0>; > + > + max31760@50 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + reg = <0x50>; > + compatible = "adi,max31760"; Messed up indentation. 4 spaces for DTS example. > + }; > + }; Best regards, Krzysztof