From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4B21FAA; Thu, 6 Jun 2024 11:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717673533; cv=none; b=cFcnG0ONODjFh/SdhJHzMg0AbJaNzYOHOGp7p16fdeHiKAS9zpfkSc0nGZX/kXuf+umAffLSDAddHolCp7w1A+ZPxvVEcCyp1o3vo/83IpD69rGhrqny4Gt/7i9LNOUhUGV5o2UJmmVUT7j/igdFURJlFjHTW73q54R1EMJnEdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717673533; c=relaxed/simple; bh=LVldkK8M41rECJCGVc6CKfxKAtGbI7b4XW5+qeNYwes=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K3GRATfa/lIGjS7SAiF2FuWx7CpUvzkA7nEnSFfFHDmyo/bBSGIxGPKbwzl8OVGg67GONb5NomW+whnYAbktikWjNxPx5b9H8wh4jfvUMLqBF7oWUsId2NUjlmryso+5gUUUOpf3/5OkOsW2nDKlXTitFe7XEkA+MwJyjRwjq38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=TRsvVgw6; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="TRsvVgw6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717673529; bh=LVldkK8M41rECJCGVc6CKfxKAtGbI7b4XW5+qeNYwes=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TRsvVgw6mTl+ZIgvPF2J6hWsru1V6hAeE9pFE45FwtFb76e08WNM+8tFtIVUKq9Z9 7OTDTyFGfdwSQFIs6njlQRyB0//L69olHhFkTBN2F5tgeh+9GFNSTrVUWdMqU1qcUo hgrGKWDFgfNMwWhCz/kgI/8eJzl0cDALMCAi41jPbxHzp/1dtfSjyM6GYd8C7dpeCJ S1A2GCGTLv5KuFzqMougFG03gNQcYP1uH4ZtzsuJPCoN0Wf2+W+rh7tRtRYbeINtZ2 BtzBGEQ7NXXd+IZ0cHtAQuMFAYpzJD8ZU2T5f4KBOYmxMu+2SquHnzui5bUF3r/vwQ UrZXB0u/Ue4bQ== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id C68F7378061A; Thu, 6 Jun 2024 11:32:07 +0000 (UTC) Message-ID: Date: Thu, 6 Jun 2024 14:32:07 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer , Algea Cao References: <20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com> <2554679.TLnPLrj5Ze@diego> <25ba8753-b7e9-4f6f-a9ad-c5266540939a@collabora.com> <2491902.uoxibFcf9D@diego> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: <2491902.uoxibFcf9D@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/6/24 1:16 PM, Heiko Stübner wrote: > Am Donnerstag, 6. Juni 2024, 11:53:23 CEST schrieb Cristian Ciocaltea: >> On 6/5/24 5:48 PM, Heiko Stübner wrote: >>> Am Samstag, 1. Juni 2024, 15:12:35 CEST schrieb Cristian Ciocaltea: >>>> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller supports >>>> the following features, among others: >>>> >>>> * Fixed Rate Link (FRL) >>>> * 4K@120Hz and 8K@60Hz video modes >>>> * Variable Refresh Rate (VRR) including Quick Media Switching (QMS), aka >>>> Cinema VRR >>>> * Fast Vactive (FVA), aka Quick Frame Transport (QFT) >>>> * SCDC I2C DDC access >>>> * TMDS Scrambler enabling 2160p@60Hz with RGB/YCbCr4:4:4 >>>> * YCbCr4:2:0 enabling 2160p@60Hz at lower HDMI link speeds >>>> * Multi-stream audio >>>> * Enhanced Audio Return Channel (EARC) >>>> >>>> Add driver to enable basic support, i.e. RGB output up to 4K@60Hz, >>>> without audio, CEC or any HDMI 2.1 specific features. >>>> >>>> Co-developed-by: Algea Cao >>>> Signed-off-by: Algea Cao >>>> Signed-off-by: Cristian Ciocaltea >>>> --- >>>> drivers/gpu/drm/bridge/synopsys/Makefile | 2 +- >>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 787 +++++++++++++++++++++++++ >>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.h | 831 +++++++++++++++++++++++++++ >>>> include/drm/bridge/dw_hdmi.h | 8 + >>>> 4 files changed, 1627 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/bridge/synopsys/Makefile b/drivers/gpu/drm/bridge/synopsys/Makefile >>>> index ce715562e9e5..8354e4879f70 100644 >>>> --- a/drivers/gpu/drm/bridge/synopsys/Makefile >>>> +++ b/drivers/gpu/drm/bridge/synopsys/Makefile >>> >>>> +static int dw_hdmi_qp_i2c_read(struct dw_hdmi *hdmi, >>>> + unsigned char *buf, unsigned int length) >>>> +{ >>>> + struct dw_hdmi_i2c *i2c = hdmi->i2c; >>>> + int stat; >>>> + >>>> + if (!i2c->is_regaddr) { >>>> + dev_dbg(hdmi->dev, "set read register address to 0\n"); >>>> + i2c->slave_reg = 0x00; >>>> + i2c->is_regaddr = true; >>>> + } >>>> + >>>> + while (length--) { >>>> + reinit_completion(&i2c->cmp); >>>> + >>>> + dw_hdmi_qp_mod(hdmi, i2c->slave_reg++ << 12, I2CM_ADDR, >>>> + I2CM_INTERFACE_CONTROL0); >>>> + >>>> + dw_hdmi_qp_mod(hdmi, I2CM_FM_READ, I2CM_WR_MASK, >>>> + I2CM_INTERFACE_CONTROL0); >>> >>> Somehow the segment handling is present in the rest of the i2c code here, but >>> not the actual handling for reads. >>> >>> The vendor-kernel does: >>> >>> - dw_hdmi_qp_mod(hdmi, I2CM_FM_READ, I2CM_WR_MASK, >>> - I2CM_INTERFACE_CONTROL0); >>> + if (i2c->is_segment) >>> + dw_hdmi_qp_mod(hdmi, I2CM_EXT_READ, I2CM_WR_MASK, >>> + I2CM_INTERFACE_CONTROL0); >>> + else >>> + dw_hdmi_qp_mod(hdmi, I2CM_FM_READ, I2CM_WR_MASK, >>> + I2CM_INTERFACE_CONTROL0); >> >> Hmm, for some reason this is not present in the stable-5.10-rock5 branch >> I've been using as an implementation reference: >> >> https://github.com/radxa/kernel/blob/stable-5.10-rock5/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c#L760 >> >> Is there an updated fork? > > I think the radxa code-base is quite old in terms of sdk-version it's based on. > Grabbing a 6.1 branch from Radxa shows it in: > https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c#L995 Indeed, I should have switched to using this one as it seems to include quite a few potentially interesting updates (will check in detail for v2). For now, we miss cdc0984c90dc ("drm/bridge: synopsys: dw-hdmi-qp: Support read ext block edid"), which provides an additional change: @@ -1086,7 +1090,7 @@ static int dw_hdmi_i2c_xfer(struct i2c_adapter *adap, i2c->is_segment = true; hdmi_modb(hdmi, DDC_SEGMENT_ADDR, I2CM_SEG_ADDR, I2CM_INTERFACE_CONTROL1); - hdmi_modb(hdmi, *msgs[i].buf, I2CM_SEG_PTR, + hdmi_modb(hdmi, *msgs[i].buf << 7, I2CM_SEG_PTR, I2CM_INTERFACE_CONTROL1); } else { if (msgs[i].flags & I2C_M_RD) Will try to grab some more displays to improve testing on my end. Thanks, Cristian