From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBB1C83F16 for ; Tue, 29 Aug 2023 09:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbjH2J2r (ORCPT ); Tue, 29 Aug 2023 05:28:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232528AbjH2J2U (ORCPT ); Tue, 29 Aug 2023 05:28:20 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3250CC5 for ; Tue, 29 Aug 2023 02:27:46 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-529fb04a234so5551201a12.3 for ; Tue, 29 Aug 2023 02:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693301213; x=1693906013; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o84nuugrdjBVbtNkpIQtkBSqIZbVDqCkc1ruQNscXdk=; b=EV4t8gBk64D0XNbgSsnnQdVfE2sUW1oNrwheARThIRcTxk/vBcAUmXPz7kChSleWq4 pYfn5knvM1XECjmUjHb+9yTtTl+MWlK+1vhAnpxxXYBZyoK8FJGYgVHzPRBZhNqwa71Q xx0/s1PyDTsKHDDSKjNYJIARMuP/bqGmqYxQ+8XQ2MAT7D5vEDUD/SGxZhZJTTnK8336 5BJCp5xZjEdgNxfaIfx9wEw+n10FmGxP8SnJihiOcii/DdE9QqJV2GMzuN9K6FpycdWA TjdoA88xaL01/BB8bfjSUqwDOSDWQ5vnbl+XKwfddlFO3IsGYeusI7eYWOAG48INynzc dZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693301213; x=1693906013; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o84nuugrdjBVbtNkpIQtkBSqIZbVDqCkc1ruQNscXdk=; b=P9IQ2JrvDF5NXF8ZcUejbJgMXLV3nl87aZSBMvz81tzdlZTDwuddmupeHHZsfYDO3e oKztuoZNfBLWbnWqddVAuOZ0DoR+1DVv4svDPf5AqXnlCftgXeH62vC/Fo9wGHLNhZP5 rTHZZ3eATfD+6Xpy3EwI35W0fIeI7xUZ6Ho9iEtv9pkgOZzaNsZIjQobBXoGky6XapYj 81/8X9cFsp7bZoNYsU2DMca2YVkQhDDSKfgFzQm8Xdh3lkQbDxWK5tGcE3EdAPBYskEm xWwXI69eRvRNTVIm+FlfQyLKxNb8wdVLUDm8soiFKsOhJxOBf+WvpaUm44GZmeNe8kHn SyJQ== X-Gm-Message-State: AOJu0Yzph9HC+baQjDSflr5NuE0SC0/MdXIdvu130SgLn+P0p48gjK1g y1YnkhOcvlYN22QLxU883hhhGw== X-Google-Smtp-Source: AGHT+IFazeQCGVcL7gfIYS4bIY2nP2zweRigE32CaayM42mlnXhdwIYaRIol4X/Jni8R+DMqmHl70g== X-Received: by 2002:aa7:d5ce:0:b0:523:69bf:2bd3 with SMTP id d14-20020aa7d5ce000000b0052369bf2bd3mr20812353eds.13.1693301212891; Tue, 29 Aug 2023 02:26:52 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.196]) by smtp.gmail.com with ESMTPSA id r14-20020aa7d58e000000b0052a1a623267sm5403877edq.62.2023.08.29.02.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 02:26:52 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 11:26:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 01/11] ARM: dts: exynos: enable polling in Exynos 4210 Content-Language: en-US To: Mateusz Majewski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Liam Girdwood , Mark Brown , Marek Szyprowski References: <20230829091853.626011-1-m.majewski2@samsung.com> <20230829091853.626011-2-m.majewski2@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230829091853.626011-2-m.majewski2@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/08/2023 11:18, Mateusz Majewski wrote: > It seems that thermal in Exynos 4210 is broken without this, as it will > never decrease cooling after increasing it. > > Signed-off-by: Mateusz Majewski > --- > arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++-- Please split unrelated patches for different subsystems into separate patchsets. > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi > index 0e27c3375e2e..aae185b7f91c 100644 > --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi > @@ -391,8 +391,14 @@ &cpu_alert2 { > }; > > &cpu_thermal { > - polling-delay-passive = <0>; > - polling-delay = <0>; > + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold. Linux coding style comments are: /* * Foo bar Best regards, Krzysztof