Re: [PATCH v2 2/3] interconnect: qcom: Add CAMNOC interconnect provider driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/08/2026 11:25, Krzysztof Kozlowski wrote:
>> +static int qcom_camnoc_set(struct icc_node *src, struct icc_node *dst)
>> +{
>> +	struct qcom_camnoc_icc_provider *cp =
>> +		to_camnoc_provider(src->provider);
>> +	unsigned long rate;
>> +
>> +	/*
>> +	 * peak_bw is the aggregated max across all consumers (kBps).
>> +	 * Consumers encode the required clock frequency directly as kBps,
>> +	 * so the conversion is simply: rate_hz = peak_bw * 1000.
>> +	 * A vote of 0 means no requirement; leave the clock at its minimum.
>> +	 */
>> +	rate = icc_units_to_bps(dst->peak_bw);
>> +
>> +	return clk_set_rate(cp->clk, rate);
> 
> This driver does nothing to the ICC hardware, no votes. It only
> translates kbps to Hz. This is not the purpose of ICC drivers.
> 
> Looks heavily incomplete.

And another proof of uselessness of this driver is that your example DTS
references ICC path between camss components. Internal camss stuff does
not need ICC representation in DT.

Best regards,
Krzysztof