From: Adrian Hunter <adrian.hunter@intel.com>
To: Zach Brown <zach.brown@ni.com>, ulf.hansson@linaro.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.
Date: Mon, 24 Oct 2016 10:34:46 +0300 [thread overview]
Message-ID: <d4547457-036a-dbb7-ddb8-b839e04949b7@intel.com> (raw)
In-Reply-To: <1477085715-30213-3-git-send-email-zach.brown@ni.com>
On 22/10/16 00:35, Zach Brown wrote:
> When the sdhci-cap-speed-modes-broken DT property is set, the driver
> will ignore the bits of the capability registers that correspond to
> speed modes.
>
> Signed-off-by: Zach Brown <zach.brown@ni.com>
> ---
> drivers/mmc/host/sdhci.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 1e25b01..59c62d3 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -22,6 +22,7 @@
> #include <linux/scatterlist.h>
> #include <linux/regulator/consumer.h>
> #include <linux/pm_runtime.h>
> +#include <linux/of.h>
>
> #include <linux/leds.h>
>
> @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1)
>
> host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES);
>
> + if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
> + "sdhci-cap-speed-modes-broken"))
It rather begs the question: if you are going to do something sdhci
specific, why not just read the whole of the caps register from DT?
> + host->caps &= ~SDHCI_CAN_DO_HISPD;
> +
> if (host->version < SDHCI_SPEC_300)
> return;
>
> host->caps1 = caps1 ? *caps1 : sdhci_readl(host, SDHCI_CAPABILITIES_1);
> +
> + if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
> + "sdhci-cap-speed-modes-broken"))
Why read it twice?
> + host->caps1 &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_SDR104 |
> + SDHCI_SUPPORT_DDR50 | SDHCI_SUPPORT_HS400);
> }
> EXPORT_SYMBOL_GPL(__sdhci_read_caps);
>
>
next prev parent reply other threads:[~2016-10-24 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 21:35 [RFC v2 0/2] Ignore capability registers when it comes to speeds and use DT binding instead Zach Brown
2016-10-21 21:35 ` [RFC v2 1/2] mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken Zach Brown
2016-10-21 21:35 ` [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set Zach Brown
2016-10-24 7:34 ` Adrian Hunter [this message]
2016-10-24 15:48 ` Zach Brown
2016-10-25 11:30 ` Adrian Hunter
2016-10-26 22:28 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4547457-036a-dbb7-ddb8-b839e04949b7@intel.com \
--to=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).