From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE2248B39D for ; Wed, 1 Jul 2026 12:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782910502; cv=none; b=XCWRM+A5V0xo0fKqOstV31HRgN+dy8WwaYnDaSJhEeddFJdaXYwQryj78bCCm5Xn8PWT1pnfCOpvXWg2bkH9RhNlMVo03IfejOKTnUkKI3BHnltpRa2Q/0c+Ra5eW41k/8dtG+dDxO6dZ+sVAzjFAkBHEIkE/m3fjy6niVI6MHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782910502; c=relaxed/simple; bh=74p5OdZcEEGetMQvAyC2B1sZkPILGKwBYM/hhxiO4nE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ra3+EEl7t5xFUaWrK2g5m7OA+jbFLBuooJusEW+F0dy0pa8gyXM1nIvlz8fhDschvgJppYF3J2muHBV/urbaIVdh1FBGXh2U6goHLnEtzb1qv+unpGq2/RthToY01lsPraIfC85IX8quqIGtPYlTCN49uIIUZ7DGflA8i76G2Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MtSdEaD6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZEPac8hB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MtSdEaD6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZEPac8hB" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661A8O7Z761381 for ; Wed, 1 Jul 2026 12:55:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nhlWz8cCtqL5ox7tNsxAOt2t1RqIW/0rkCL7ft+bkww=; b=MtSdEaD6slx+sUQx jGrKqq9oOpitSm3+7YllihpIWFsbms/IQtzHZpq0YzLf9l+yfGPclBHNT5MsT1XL lN+7julGIpxpbGGQo7NWrz4wsu59XWiamJsG7+6wupLbQNJTUlXE1xxvo8wOo/Sv DvxwW5ocUcHqJmAXGEXdc17uisw03Pg9MNmhZ5K7NpE0peghZkmrFVzPCUiVqUxx kh3tvH6bJ+pLCp4X3ldt5lRaHJxG7TzIT3aGhjmQ42+ooT6VR2TuJty2cYS6MkUu LBkUTNzNLGLq7avLyaVmFnyzwD0cEd22Tix9/5Vv4BxXzjM7AlTNwxsqpLtfdF4V cWeD7w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f50sd0q13-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 12:55:00 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84240683a82so647895b3a.1 for ; Wed, 01 Jul 2026 05:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782910500; x=1783515300; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nhlWz8cCtqL5ox7tNsxAOt2t1RqIW/0rkCL7ft+bkww=; b=ZEPac8hB71OdogfNBzw6EwZwbHja3MRCYsWzaBcL3sJxc58XwqcdAOmRG/e+bZD6zF 9oUwFogrcMBGJeBjpDVK/fzguHhRfuzE9wuxTm2vRKrjkBQSTPTDwG1Cp5oBbN/GVbKH JHpQWaicjTjahXMcUUBoMHMIY18IeJKGfXoey+0jTjN5fzcvUXePyuzgUaLCocJoqq3T /6nlgMF193pnaFsHmS32186FYnWmtDcy2VSrbvveuo9L2+vywpZss+84+aFqRltawPqz FAru0PZNp7JMuwBNxGxND6B38KtGKWRdO0Vx+nElHuz4BDo4LF/85br0+K35ps7k/Eex 6OzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782910500; x=1783515300; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nhlWz8cCtqL5ox7tNsxAOt2t1RqIW/0rkCL7ft+bkww=; b=XvQFtYKiCB6RQqYjPDDz6UAGdGDY1iosoH/AUBHoKD2kvIgqKzdCLp/66qoB39edEQ r0S9zpFmhleKpZI6Ln+KCY2HPlZTSp65Ps6Y5EE08W8TkHFtktgGSkn0cKsvcXT1Kv4A 0aSkrILRsY858nDVLyO5PepewcrODz/YEw2tMpbjHb+4wgCmHJCpEFUzydrteIDgq7o6 DSZWWjr2cL9BZNnAbHHOyPDKRN/sUyZTm2oMHXteahwyyrTvnKdjrf1VCJaYoQrcbVH/ H8NK13lSxpUebxbjth4UfmWaZGEGUESGH/KAEGg8TVtoiyF8RkCuJLez0VgrGKJVcmC+ liQw== X-Forwarded-Encrypted: i=1; AHgh+RoppnlzzBTzGFVUYKp0GHEfmyZ+twqJJ3oEZbDq4WTqR5b922DzbY9mRnkJCZzYVYdEJgX7NgChryEU@vger.kernel.org X-Gm-Message-State: AOJu0YyR0T+mDVnWglH1igbaiqjxKh9x9TXovKbF1a9tYREAqxzRAMY4 Ue2vjX/51BL6OX6dwrP4c1AaxQ+pVNkx0FXnr5XWN5cHnj0rtfQaFLvnvGQ66GDiW9bTycJV0mo gkyz3nWZ4zanDmR8jE2TntxfDSrZ1bnLZHcrjrGxBKbZ8vbq8dbDxrENkwsJnzFR6 X-Gm-Gg: AfdE7cm1W7nM/EZwkF9+n3iT+k8hYQyWOJZgm4O1J5ap65J+uf1rDV7Yw3ESdCQWGzb 6Dh30bWPcHMgXgSOS+odJ3FFEe1gE38xhxmdtIawMRqH9uqTsW1lhj7X+7CEs5C/yTk3TcdszVg FRjpg2ia3e6sRpmpVNaA/l8YJSPzfKFJy+lPLQzHgnoqwrYwQnYRUiA9nhuUEPs2fTCgu34QmIY rBApAjoq63wTDEJHIlTDjJMpcbpC1vMjcaDekCv8qvLMxE4BAP8Y5E9gX42XelKtrnLo0Wetylr Bc3cjpGgwkcCz6mottQW7r3ZFFi40D+xhfU5pWWD5k3VQ95c5j0t4bmWBrQY5xZNuv019x6t8sx C/6SwsZk9eaDzAs4DWkKmVPoyZnYxxmtiXmk2hxiP77X+aR4720lxEeL8tdKcUQeZDWy7UEWLwH c= X-Received: by 2002:aa7:9315:0:b0:847:888f:9b0f with SMTP id d2e1a72fcca58-847bf944a63mr1320494b3a.15.1782910499762; Wed, 01 Jul 2026 05:54:59 -0700 (PDT) X-Received: by 2002:aa7:9315:0:b0:847:888f:9b0f with SMTP id d2e1a72fcca58-847bf944a63mr1320474b3a.15.1782910499241; Wed, 01 Jul 2026 05:54:59 -0700 (PDT) Received: from [10.133.33.29] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a02cdfb7sm4008598b3a.39.2026.07.01.05.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 05:54:58 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 20:54:50 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: arm: coresight-tnoc: Add standalone qcom,coresight-agtnoc compatible To: Konrad Dybcio , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260701-fix-tracenoc-probe-issue-v4-0-aefab449a470@oss.qualcomm.com> <20260701-fix-tracenoc-probe-issue-v4-1-aefab449a470@oss.qualcomm.com> <20260701-stirring-piculet-of-vastness-a361e5@quoll> <4117c406-0d75-4eb1-842e-1d346b7fbf99@oss.qualcomm.com> <9aa63427-ba41-436d-ab19-a533082d336a@kernel.org> <62ac6887-1551-490b-b42b-2661d7152734@oss.qualcomm.com> <7838f7c3-0f38-4e93-a9c1-88f387e78ca9@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <7838f7c3-0f38-4e93-a9c1-88f387e78ca9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Z+3c2nRA c=1 sm=1 tr=0 ts=6a450e24 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=i5S6TmXcA3_pwKZvcRIA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: 6KITBm4mFWA6X_VOjiRGu7tWwJiV5-x4 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDEzNSBTYWx0ZWRfXxa5RwiedcREp OEF293RM7lmZvSaTtncGcNuCNWdmF2IK/yMnCbmtgBL1CkDjmFGQtPRzOBASmMpb9BhkbMHUYfD s1KIpXopZOnXNO78knC37K3Qjt0t6uk= X-Proofpoint-GUID: 6KITBm4mFWA6X_VOjiRGu7tWwJiV5-x4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDEzNSBTYWx0ZWRfX88Gv9BXbqGD7 C/er9g9IsJtOWjMFf1HQUXxQVdfvf1ddEdB+QRlMe32fRAR2KYQiScmEA2lQ3AQfsRJdMcpcDqp Bie3q9sN9b75Cz9DVm6CCwzYw8IRE63J4BO3/JUxFX8+uX4Er71gcxXAwteY2W+bVoP2SnJ0WzV YS/FiFXSDWgx7WKILQ48eXGMgv0H4ZmmYtn/fG4tu1TnwPE5EKQum/EI9rLzPgWknYzZKOdeUPy yFeomyj/KFwETq7+xcjp4N5Va7j+Psa/Bvp6AkBms1I/AYZ05+sigU55EuanN1x7DIYqTdTbsBy CWf2SlWHm12qxHwRScO3k3TSThn5xzy6oc6paaeN63V8YnBPqmva2PIfQMjrA3kALHaDLV9Ptpm /aH5GWIJHIk5LN/G7R9Y8wa/giEVyxjE5UHuFRtXRBEHMdvCukGQrBanX+B4v8ZRHrVzjh9DOIX Pt2stAaR6TLT0kHj1/A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010135 On 7/1/2026 7:02 PM, Konrad Dybcio wrote: > On 7/1/26 9:31 AM, Jie Gan wrote: >> >> >> On 7/1/2026 3:26 PM, Krzysztof Kozlowski wrote: >>> On 01/07/2026 09:16, Jie Gan wrote: >>>> >>>> >>>> On 7/1/2026 2:57 PM, Krzysztof Kozlowski wrote: >>>>> On Wed, Jul 01, 2026 at 09:53:41AM +0800, Jie Gan wrote: >>>>>> The TNOC compatible previously only allowed the two-string AMBA form >>>>>> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the >>>>>> AMBA bus. >>>>>> >>>>>> Convert the compatible to a oneOf and add a standalone >>>>>> "qcom,coresight-agtnoc" compatible alongside the existing AMBA form. The >>>>>> standalone string carries no "arm,primecell" entry, so the device is >>>>>> created on the platform bus instead of the AMBA bus. > > [...] > >>>> AMBA primecell identification. The purpose of the new compatible is to >>>> clearly distinguish this platform-specific case from the standard >>>> AMBA-based implementation. Or shall I re-use the existing compatible >>>> "qcom,coresight-tnoc" as platform standalone compatible? >>>> >>>> We already have a similar pattern for the interconnect TraceNoC device, >>>> which uses the platform-specific compatible string qcom,coresight-itnoc. >>> I do not see there a fake, duplicated compatible for the same device. >>> Can you elaborate how is that relevant? >> >> Will fix it by removing AMBA related description. >> >> Shall I update the clock name from apb_pclk to apb as a platform device? > > Why? For the previous platform devices, we got comments to add the clock-name with "apb" instead of "apb_pclk". Please check the qcom,coresight-ctcu.yaml and qcom,coresight-itnoc.yaml Thanks, Jie > > Konrad