From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] ARM: dts: qcom: Add apq8064 CoreSight components Date: Thu, 17 Nov 2016 14:16:06 -0800 Message-ID: References: <20161117153609.11705-1-georgi.djakov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161117153609.11705-1-georgi.djakov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Georgi Djakov , andy.gross@linaro.org Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, mathieu.poirier@linaro.org, zhang.chunyan@linaro.org, iivanov.xz@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 11/17/2016 07:36 AM, Georgi Djakov wrote: > From: "Ivan T. Ivanov" > > Add initial set of CoreSight components found on Qualcomm's > 8064 chipset. > > Signed-off-by: Ivan T. Ivanov > Signed-off-by: Georgi Djakov > --- > arch/arm/boot/dts/qcom-apq8064-coresight.dtsi | 196 ++++++++++++++++++++++++++ Why not put this inside the soc file? This would be the first time we add a new file for something that's inside the SoC node that probably won't change thereafter. At least for pins I slightly agree with having a different file, we're adding more and more things there so it's nice to have a consolidated place of all possible configurations to choose from. But here it's mostly a static device description so what's the gain? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project