[PATCH v2 0/1] Update apq8016 lpass-cpu compat string

[PATCH v2 0/1] Update apq8016 lpass-cpu compat string

[Bryan O'Donoghue]

V2:
- I polled Krzysztof about the right way to do this and then completely
  forgot to implement it like we discussed. Here's V2 the way we agreed. 

V1:
Per discussion with Krzysztof on this yesterday:
https://lore.kernel.org/linux-arm-msm/20220908105720.857294-1-bryan.odonoghue@linaro.org/T/#mb16386b0b6d45de6a7d7e01733d5b6a7d0b85c25

Mark the old lpass compat string as deprecated in yaml and leave a comment
in the commit log to explain new SoC additions should use the corrected
version.

Bryan O'Donoghue (1):
  ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as
    deprecated

 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml   | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

-- 
2.37.3

[PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Bryan O'Donoghue]

We've had some discongruity in the compatible string of the lpass for 8916
for a while.

Mark the old compat as deprecated. New SoC additions such as msm8936 and
msm8939 should use the compat string "qcom,apq8016-lpass-cpu".

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 .../devicetree/bindings/sound/qcom,lpass-cpu.yaml   | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
index ef18a572a1ff3..e2c0f573a3084 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
@@ -18,11 +18,14 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,lpass-cpu
-      - qcom,apq8016-lpass-cpu
-      - qcom,sc7180-lpass-cpu
-      - qcom,sc7280-lpass-cpu
+    oneOf:
+      - enum:
+        - qcom,lpass-cpu
+        - qcom,apq8016-lpass-cpu
+        - qcom,sc7180-lpass-cpu
+        - qcom,sc7280-lpass-cpu
+      - const: qcom,lpass-cpu-apq8016
+        deprecated: true
 
   reg:
     minItems: 1
-- 
2.37.3

Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Krzysztof Kozlowski]

On 10/09/2022 03:42, Bryan O'Donoghue wrote:
> We've had some discongruity in the compatible string of the lpass for 8916
> for a while.
> 
> Mark the old compat as deprecated. New SoC additions such as msm8936 and
> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml   | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index ef18a572a1ff3..e2c0f573a3084 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -18,11 +18,14 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,lpass-cpu
> -      - qcom,apq8016-lpass-cpu
> -      - qcom,sc7180-lpass-cpu
> -      - qcom,sc7280-lpass-cpu
> +    oneOf:
> +      - enum:
> +        - qcom,lpass-cpu
> +        - qcom,apq8016-lpass-cpu

The indentation looks odd here. Are you sure it passes the `make
dt_binding_check`?


Best regards,
Krzysztof

Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Bryan O'Donoghue]

On 10/09/2022 08:55, Krzysztof Kozlowski wrote:
> On 10/09/2022 03:42, Bryan O'Donoghue wrote:
>> We've had some discongruity in the compatible string of the lpass for 8916
>> for a while.
>>
>> Mark the old compat as deprecated. New SoC additions such as msm8936 and
>> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml   | 13 ++++++++-----
>>   1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> index ef18a572a1ff3..e2c0f573a3084 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> @@ -18,11 +18,14 @@ description: |
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - qcom,lpass-cpu
>> -      - qcom,apq8016-lpass-cpu
>> -      - qcom,sc7180-lpass-cpu
>> -      - qcom,sc7280-lpass-cpu
>> +    oneOf:
>> +      - enum:
>> +        - qcom,lpass-cpu
>> +        - qcom,apq8016-lpass-cpu
> 
> The indentation looks odd here. Are you sure it passes the `make
> dt_binding_check`?

It does yeah

---
bod

Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Rob Herring]

On Sat, 10 Sep 2022 02:42:06 +0100, Bryan O'Donoghue wrote:
> We've had some discongruity in the compatible string of the lpass for 8916
> for a while.
> 
> Mark the old compat as deprecated. New SoC additions such as msm8936 and
> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml   | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Bryan O'Donoghue]

On 10/09/2022 15:53, Rob Herring wrote:
> On Sat, 10 Sep 2022 02:42:06 +0100, Bryan O'Donoghue wrote:
>> We've had some discongruity in the compatible string of the lpass for 8916
>> for a while.
>>
>> Mark the old compat as deprecated. New SoC additions such as msm8936 and
>> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml   | 13 ++++++++-----
>>   1 file changed, 8 insertions(+), 5 deletions(-)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> 
> dtschema/dtc warnings/errors:
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 

Bah, you were right.

I didn't see this in the noise generated by the tool

/home/deckard/Development/qualcomm/qlt-kernel/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: 
[warning] wrong indentation: expected 10 but found 8 (indentation)

Is there some way to slim the output down to just the yaml file I am 
interested in ?

Dmitry submitted a patch for this at some stage I think

Re: [PATCH v2 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated

[Krzysztof Kozlowski]

On 10/09/2022 19:22, Bryan O'Donoghue wrote:
> Bah, you were right.
> 
> I didn't see this in the noise generated by the tool
> 
> /home/deckard/Development/qualcomm/qlt-kernel/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml:23:9: 
> [warning] wrong indentation: expected 10 but found 8 (indentation)
> 
> Is there some way to slim the output down to just the yaml file I am 
> interested in ?
> 
> Dmitry submitted a patch for this at some stage I think

It's since long time and documented in writing-schema.

Best regards,
Krzysztof