From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97657C77B60 for ; Wed, 26 Apr 2023 11:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240309AbjDZLyh (ORCPT ); Wed, 26 Apr 2023 07:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240581AbjDZLyg (ORCPT ); Wed, 26 Apr 2023 07:54:36 -0400 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADEE05B9A; Wed, 26 Apr 2023 04:53:48 -0700 (PDT) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 7EC50D27; Wed, 26 Apr 2023 13:53:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1682509983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RGgieoJu2M0mWFk816sGTOLEYpz179EmxMrNMNHPmVs=; b=FJ73v2j09tV5wSSysU854ogO76xRRAlxU4aMTuFnoTdmNaR3BzbHZqcncONGr7tz9DsLbL ztZm4oTI+ZOfH0Qk6k9FZf/9sMS4GLBVCwh7vekTd5q1gn4zhjRQFhqxb7gZwQvceqL4Ox eugvqzb/Z6vVbrCJVhXCk75vSJf31YIUlrttLhrj7Cn0OL0lDMMq0IZdNVMBo4PYw1aukN mf2huzqw9jP90/Xabywro7N7VYyyxhqX9KDDBpMgRdC6+CiSdLLcWXEnS9vwYOiYwccmAy bc0MYlfVptdwJZgwbG0FXvTujcqQJWv/z7w3Qi3JRlrZOpLAPrqCwQ4Pwev3bg== MIME-Version: 1.0 Date: Wed, 26 Apr 2023 13:53:03 +0200 From: Michael Walle To: "Sahin, Okan" Cc: andy.shevchenko@gmail.com, Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] gpio: ds4520: Add ADI DS4520 Regulator Support In-Reply-To: References: <20230327130010.8342-1-okan.sahin@analog.com> <20230327130010.8342-3-okan.sahin@analog.com> <25e1fda4b6df2d10444d7eca3cd0e387@walle.cc> <1ff70a97dfbcaddd69029001ce99bb69@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, > I think I understand what you are trying to say so far. I did not have > too much > experience related to gpio. I will set pull_up register in .set_config > However, I did not understand where its parameters come from. > set_config(struct gpio_chip *chip, unsigned int offset, > unsigned long config) > It might be trivial question, but Where does config come from? Others have to answer that one as I don't have that much experience either. > At the end, I should rewrite the code using regmap_gpio, right? So if I > rewrite > code using regmap_gpio, how can I replace set_config(...)? You'd have to add a .set_config to gpio_regmap_config and then in gpio_regmap_register(): gpio->set_config = config->set_config; I don't think it makes sense to have a default implementation in gpio-regmap, the variances between "simple" gpio controllers might be too broad. -michael