From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: nl250060@ncr.com, Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] gpio: dt-bindings: add new property to wd,mbl-gpio bindings
Date: Thu, 26 Jan 2023 13:28:48 +0100 [thread overview]
Message-ID: <d4a70ab2-c5a2-2478-3fa9-c703c1619252@linaro.org> (raw)
In-Reply-To: <20230126-gpio-mmio-fix-v1-1-8a20ce0e8275@ncr.com>
On 26/01/2023 11:17, Niall Leonard via B4 Submission Endpoint wrote:
> From: Niall Leonard <nl250060@ncr.com>
Subject: missing "wd,mbl-gpio:" prefix.
Subject: drop second/last, redundant "bindings". The "dt-bindings"
prefix is already stating that these are bindings.
>
> Added optional "no-input" property
Missing full stop.
>
> Signed-off-by: Niall Leonard <nl250060@ncr.com>
> ---
> Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt b/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> index 038c3a6a1f4d..9405f9dad522 100644
> --- a/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> @@ -18,6 +18,7 @@ Required properties:
>
> Optional properties:
> - no-output: GPIOs are read-only.
> + - no-input: GPIOs are write-only. Read is via a shadow register.
Why this property is needed? Why driver cannot always use shadow register?
Anyway, please convert the bindings to DT schema first (see
writing-schema and example-schema).
Documentation/devicetree/bindings/writing-schema.rst
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-26 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:17 [PATCH 0/3] Introduce new optional property to mark port as write only Niall Leonard via B4 Submission Endpoint
2023-01-26 10:17 ` [PATCH 1/3] gpio: dt-bindings: add new property to wd,mbl-gpio bindings Niall Leonard via B4 Submission Endpoint
2023-01-26 12:28 ` Krzysztof Kozlowski [this message]
2023-01-27 11:39 ` Leonard, Niall
2023-01-29 15:59 ` Krzysztof Kozlowski
2023-01-30 13:20 ` Leonard, Niall
2023-01-30 18:37 ` Rob Herring
2023-01-31 10:25 ` Leonard, Niall
2023-01-27 12:57 ` Linus Walleij
2023-01-26 10:17 ` [PATCH 2/3] gpio: Add new flag BGPIOF_NO_INPUT Niall Leonard via B4 Submission Endpoint
2023-01-27 12:54 ` Linus Walleij
2023-01-31 10:22 ` Leonard, Niall
2023-01-26 10:17 ` [PATCH 3/3] gpio: mmio: Use " Niall Leonard via B4 Submission Endpoint
2023-01-27 12:53 ` Linus Walleij
2023-01-29 16:01 ` Krzysztof Kozlowski
2023-01-31 10:23 ` Leonard, Niall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a70ab2-c5a2-2478-3fa9-c703c1619252@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nl250060@ncr.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).