devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liu Ying <victor.liu@nxp.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, tglx@linutronix.de
Subject: Re: [PATCH 03/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine
Date: Mon, 8 Jul 2024 16:05:35 +0200	[thread overview]
Message-ID: <d4ad0701-231a-474f-927c-d21d6785f9ff@kernel.org> (raw)
In-Reply-To: <ea8a5f78-65a5-4be8-9e15-57351a839f52@nxp.com>

On 08/07/2024 08:47, Liu Ying wrote:
> On 07/07/2024, Krzysztof Kozlowski wrote:
>> On 05/07/2024 11:09, Liu Ying wrote:
>>> i.MX8qxp Display Controller pixel engine consists of all processing units
>>> that operate in the AXI bus clock domain.  Command sequencer and interrupt
>>> controller of the Display Controller work with AXI bus clock, but they are
>>> not in pixel engine.
>>>
>>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>>> ---
>>
>>
>>> +
>>> +        extdst@56180a40 {
>>> +            compatible = "fsl,imx8qxp-dc-extdst";
>>> +            reg = <0x56180a40 0x7>, <0x56186000 0x400>;
>>> +            reg-names = "pec", "cfg";
>>> +            interrupt-parent = <&dc0_intc>;
>>> +            interrupts = <12>, <13>, <14>;
>>> +            interrupt-names = "shdload", "framecomplete", "seqcomplete";
>>> +            fsl,dc-ed-id = <5>;
>>> +        };
>>> +
>>> +        fetchwarp@56180a60 {
>>> +            compatible = "fsl,imx8qxp-dc-fetchwarp";
>>> +            reg = <0x56180a60 0x4>, <0x56186400 0x400>;
>>
>> Aha, one word for address range.
> 
> Sorry, I don't get your idea here.

How many words are in the first IO address range?

One.

That is not a separate device.

> 
>>
>> Sorry, these are not separate devices.
> 
> Hmm, again, Maxime suggested to use separate devices.

To some level you can create separate devices, but for one register?

Best regards,
Krzysztof


  reply	other threads:[~2024-07-08 14:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  9:09 [PATCH 00/10] Add Freescale i.MX8qxp Display Controller support Liu Ying
2024-07-05  9:09 ` [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units Liu Ying
2024-07-07 13:58   ` Krzysztof Kozlowski
2024-07-08  6:30     ` Liu Ying
2024-07-08 20:04       ` Rob Herring
2024-07-09  7:36         ` Liu Ying
2024-07-05  9:09 ` [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-07-07 13:59   ` Krzysztof Kozlowski
2024-07-08  6:40     ` Liu Ying
2024-07-08 14:04       ` Krzysztof Kozlowski
2024-07-08 14:52         ` Maxime Ripard
2024-07-09  6:50           ` Krzysztof Kozlowski
2024-07-18 15:53             ` Maxime Ripard
2024-07-05  9:09 ` [PATCH 03/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-07-07 14:02   ` Krzysztof Kozlowski
2024-07-08  6:47     ` Liu Ying
2024-07-08 14:05       ` Krzysztof Kozlowski [this message]
2024-07-09  6:50         ` Liu Ying
2024-07-05  9:09 ` [PATCH 04/10] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-07-07 14:01   ` Krzysztof Kozlowski
2024-07-08  6:51     ` Liu Ying
2024-07-08 14:09       ` Krzysztof Kozlowski
2024-07-09  7:05         ` Liu Ying
2024-07-05  9:09 ` [PATCH 05/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller Liu Ying
2024-07-07 14:03   ` Krzysztof Kozlowski
2024-07-08  7:01     ` Liu Ying
2024-07-05  9:09 ` [PATCH 06/10] drm/imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-07-05  9:09 ` [PATCH 07/10] drm/imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-07-05  9:09 ` [PATCH 08/10] drm/imx: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-07-05  9:09 ` [PATCH 09/10] drm/imx: Add i.MX8qxp Display Controller KMS Liu Ying
2024-07-07 19:16   ` Markus Elfring
2024-07-08  6:21     ` Liu Ying
2024-07-08  7:09       ` [09/10] " Markus Elfring
2024-07-08  7:33         ` Krzysztof Kozlowski
2024-07-05  9:09 ` [PATCH 10/10] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller Liu Ying
2024-07-05 19:02   ` Frank Li
2024-07-08  6:14     ` Liu Ying
2024-07-05 12:57 ` [PATCH 00/10] Add Freescale i.MX8qxp Display Controller support Francesco Dolcini
2024-07-08  7:03   ` Liu Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ad0701-231a-474f-927c-d21d6785f9ff@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tzimmermann@suse.de \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).