From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA42C38142 for ; Wed, 1 Feb 2023 16:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231718AbjBAQPd (ORCPT ); Wed, 1 Feb 2023 11:15:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231285AbjBAQPc (ORCPT ); Wed, 1 Feb 2023 11:15:32 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 094F5B3 for ; Wed, 1 Feb 2023 08:15:31 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id hn2-20020a05600ca38200b003dc5cb96d46so1777536wmb.4 for ; Wed, 01 Feb 2023 08:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Akhmn5actGLIdiBKY1RGD6tVXjYHB9tU5fwD4dusjfk=; b=zBQ73vo7dvJsJ+CtZXk/NRBVjxrmhbQUB76WVjxpO0oevyeVPpEwF9Lh7S3wdr2k/R 7ziUWECCiCoJO25xCbmKULg+l7tOaIu9Pbw/UAEo50BJR7wfaKwwBo0hRBzYrncVnbJb VxZVQ3p3jwVzbZWyq0nFo5pOttVFu2u9HAJvzXMo2z1ueiwrsa6THSAmbiJsqh3IHiNS kq2oFtkDH9/t/7ri3Mmq0o3X+89mVhrfSJf/+Bn+A6UPCChcvX2vUsAwVxFaJUcNEoOw GVwryHvoEP6+stLVooB16s0HoiSWYMqMCs+798XWMu+1AQRZfOB69je8Z/EhwLnVQXtK 3Q7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Akhmn5actGLIdiBKY1RGD6tVXjYHB9tU5fwD4dusjfk=; b=mx/KB/k4cyFdR9dSUDJpV9qBBgxKgcgckwigcaoVocgcgUBqh3QM87n/szNTPEMp9C wW8NWsEkEdv7lervK3L00qTrXy08iq+1mIA+9dXw45deIjl5PdzqmOZL+oM7NC5vpjNR RIhHq1JtMawXdSMm5O6lrwRqCAYfxA7r82brZBOHSUSHzH11E7Ttez4AQrgze9xVnh1q PcxO+8OlZpUJCil9kU90iSRywscBAkOUzd8EM+J4QfRiQobVnzPIgkZvGmeMRYzVcOaT JBdxEQai8+KdyJ8qkzUBn0kEJSswiZBJy6ewq00MGSBG3ayeQNKDcyn23j7ZJ1USrh+A sQ2A== X-Gm-Message-State: AO0yUKXxCWH/EGPD9/2BwwFvQJBMQjkbWLDaOxzD70WG4XPNlqmWrqj1 cQfgsgHxvzxDhMBo+PlAGMBLzw== X-Google-Smtp-Source: AK7set9b2w9VpCLvBN3+NqeaahdJlaPN4olEcUe0FTfkdcB4Kt9xYgGmXdXsMwrGnwEQhDaVIJmfmA== X-Received: by 2002:a05:600c:1e0b:b0:3da:1e35:dfec with SMTP id ay11-20020a05600c1e0b00b003da1e35dfecmr2773018wmb.4.1675268129611; Wed, 01 Feb 2023 08:15:29 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l13-20020adff48d000000b002366e3f1497sm17683823wro.6.2023.02.01.08.15.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 08:15:29 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 17:15:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 3/4] dt-bindings: input: pwm-beeper: add volume Content-Language: en-US To: Manuel Traut , linux-kernel@vger.kernel.org Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Frieder Schrempf , linux-input@vger.kernel.org, devicetree@vger.kernel.org References: <20230201152128.614439-1-manuel.traut@mt.com> <20230201152128.614439-4-manuel.traut@mt.com> From: Krzysztof Kozlowski In-Reply-To: <20230201152128.614439-4-manuel.traut@mt.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/02/2023 16:21, Manuel Traut wrote: > Adds an array of supported volume levels and a default volume level. Adds -> Add > > Signed-off-by: Manuel Traut > --- > .../devicetree/bindings/input/pwm-beeper.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > index 1ebc3a46d934..6599e28ba5e6 100644 > --- a/Documentation/devicetree/bindings/input/pwm-beeper.yaml > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > @@ -25,6 +25,21 @@ properties: > beeper-hz: > description: bell frequency in Hz > > + volume-levels-bp: > + description: > > + Array of PWM duty cycle values that correspond to > + linear volume levels. These need to be in the range of > + 0 to 5000, while 0 means 0% duty cycle (mute) and 5000 > + means 50% duty cycle (max volume). Is range 0-5000 limitation of the device? If so, this should not be free-form text, but "maximum: 5000" (minimum is 0 anyway). > + Please note that the actual volume of most beepers is > + highly non-linear, which means that low volume levels > + are probably somewhere in the range of 10 to 300 (0.1-3% > + duty cycle). Best regards, Krzysztof