From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jinlong Mao <quic_jinlmao@quicinc.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>, Leo Yan <leo.yan@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
coresight@lists.linaro.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: coresight: Update the pattern of ete node name
Date: Thu, 21 Dec 2023 09:44:17 +0100 [thread overview]
Message-ID: <d4c6c32f-b1cf-4cf2-9c52-85fa8c1ed73f@linaro.org> (raw)
In-Reply-To: <16932826-fcc2-49d3-95ab-201eff729360@quicinc.com>
On 21/12/2023 09:36, Jinlong Mao wrote:
>
>
> On 12/21/2023 4:17 PM, Krzysztof Kozlowski wrote:
>> On 21/12/2023 09:15, Jinlong Mao wrote:
>>>
>>>
>>> On 12/21/2023 4:12 PM, Krzysztof Kozlowski wrote:
>>>> On 21/12/2023 04:28, Jinlong Mao wrote:
>>>>>>> diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>>>>>>> index f725e6940993..cbf583d34029 100644
>>>>>>> --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>>>>>>> +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>>>>>>> @@ -23,7 +23,7 @@ description: |
>>>>>>>
>>>>>>> properties:
>>>>>>> $nodename:
>>>>>>> - pattern: "^ete([0-9a-f]+)$"
>>>>>>> + pattern: "^ete-([0-9a-f]+)$"
>>>>>>
>>>>>> My concerns are not resolved. Why is it here in the first place?
>>>>>
>>>>> Hi Krzysztof,
>>>>>
>>>>> ETE is acronym of embedded trace extension. The number of the name is
>>>>> the same as the number of the CPU it belongs to.
>>>>
>>>> This is obvious and was not my question.
>>>
>>> Do you mean why the pattern match of the node name is added here ?
>>
>> Yes, especially that it is requiring a non-generic name.
>>
>>>
>>> This node should not have the node name match, right ?
>>
>> Usually. For sure shouldn't be for non-generic names.
>>
> Hi Suzuki,
>
> Can we remove the pattern match of the node name and use a generic name
> "ete" for the ete DT nodes ?
"ete" is not a generic name. What is generic here? It's an acronym of
some specific device name.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-21 8:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 14:05 [PATCH v1 0/2] arm64: dts: qcom: Add coresight nodes for sm8450 Mao Jinlong
2023-12-20 14:05 ` [PATCH v1 1/2] dt-bindings: arm: coresight: Update the pattern of ete node name Mao Jinlong
2023-12-20 15:50 ` Krzysztof Kozlowski
2023-12-21 3:28 ` Jinlong Mao
2023-12-21 8:12 ` Krzysztof Kozlowski
2023-12-21 8:15 ` Jinlong Mao
2023-12-21 8:17 ` Krzysztof Kozlowski
2023-12-21 8:36 ` Jinlong Mao
2023-12-21 8:44 ` Krzysztof Kozlowski [this message]
2023-12-26 1:50 ` Jinlong Mao
2023-12-26 9:36 ` Krzysztof Kozlowski
2023-12-28 11:02 ` James Clark
2023-12-29 3:21 ` Jinlong Mao
2023-12-20 14:05 ` [PATCH v1 2/2] arm64: dts: qcom: Add coresight nodes for sm8450 Mao Jinlong
2023-12-20 14:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4c6c32f-b1cf-4cf2-9c52-85fa8c1ed73f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).